netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] - libxt_bpf: use correct shell term in man page description
@ 2013-04-08  8:14 Mart Frauenlob
  2013-04-19  0:16 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Mart Frauenlob @ 2013-04-08  8:14 UTC (permalink / raw)
  To: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

Hello,

use 'command substitution' as correct shell term instead of 'backticks'.
Also mention backquotes and `$()' form.

btw: After compiling in the git directory the nfbpf_compile binary is 
shown as new file by git. Should that be so?

Best regards

Mart

[-- Attachment #2: libxt_bpf.man-Use-correct-shell-term-in-man-page.patch --]
[-- Type: text/plain, Size: 964 bytes --]

>From 536c34c67b4149e7c83f474350d8a5fbaaa0fa6d Mon Sep 17 00:00:00 2001
From: Mart Frauenlob <mart.frauenlob@chello.at>
Date: Mon, 8 Apr 2013 10:03:22 +0200
Subject: [PATCH] libxt_bpf.man: Use correct shell term in man page.

---
 extensions/libxt_bpf.man |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/extensions/libxt_bpf.man b/extensions/libxt_bpf.man
index 4120a23..675effd 100644
--- a/extensions/libxt_bpf.man
+++ b/extensions/libxt_bpf.man
@@ -2,7 +2,7 @@ Match using Linux Socket Filter. Expects a BPF program in decimal format. This
 is the format generated by the \fBnfbpf_compile\fP utility.
 .TP
 \fB\-\-bytecode\fP \fIcode\fP
-Pass the code in backtick format as argument.
+Pass the code as argument using command substitution (backquotes or `$()' form).
 .PP
 The code format is similar to the output of the tcpdump -ddd command: one line
 that stores the number of instructions, followed by one line for each
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] - libxt_bpf: use correct shell term in man page description
  2013-04-08  8:14 [PATCH] - libxt_bpf: use correct shell term in man page description Mart Frauenlob
@ 2013-04-19  0:16 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-04-19  0:16 UTC (permalink / raw)
  To: Mart Frauenlob; +Cc: netfilter-devel

On Mon, Apr 08, 2013 at 10:14:17AM +0200, Mart Frauenlob wrote:
> Hello,
> 
> use 'command substitution' as correct shell term instead of 'backticks'.
> Also mention backquotes and `$()' form.

I have applied this change to clarify this:

diff --git a/extensions/libxt_bpf.man b/extensions/libxt_bpf.man
index 4120a23..3dd4830 100644
--- a/extensions/libxt_bpf.man
+++ b/extensions/libxt_bpf.man
@@ -2,7 +2,7 @@ Match using Linux Socket Filter. Expects a BPF program
in decimal format. This
 is the format generated by the \fBnfbpf_compile\fP utility.
 .TP
 \fB\-\-bytecode\fP \fIcode\fP
-Pass the code in backtick format as argument.
+Pass the BPF bytes code format (described in the example below).
 .PP
 The code format is similar to the output of the tcpdump -ddd command: one line
 that stores the number of instructions, followed by one line for each

> btw: After compiling in the git directory the nfbpf_compile binary
> is shown as new file by git. Should that be so?

I have also fixed this.

Regards.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-19  0:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-08  8:14 [PATCH] - libxt_bpf: use correct shell term in man page description Mart Frauenlob
2013-04-19  0:16 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).