From: Simon Horman <horms@verge.net.au>
To: Julian Anastasov <ja@ssi.bg>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Hans Schillstrom <hans@schillstrom.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>
Subject: Re: [PATCH ipvs-next] ipvs: Remove rcu_read_unlock();rcu_read_lock();
Date: Fri, 26 Apr 2013 09:28:16 +0900 [thread overview]
Message-ID: <20130426002813.GD29748@verge.net.au> (raw)
In-Reply-To: <alpine.LFD.2.00.1304252224250.1948@ja.ssi.bg>
On Thu, Apr 25, 2013 at 10:46:55PM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Thu, 25 Apr 2013, Eric Dumazet wrote:
>
> > On Thu, 2013-04-25 at 22:36 +0900, Simon Horman wrote:
> >
> > > Ok, leaving it seems reasonable.
> > > Pablo, do you have any objections?
> >
> > I have objections.
> >
> > I would _add_ a cond_resched() there to explicitly do what we want
> >
> > Maybe a macro/inline doing this already exists.
> >
> > static void inline cond_resched_rcu_lock(void)
> > {
> > if (need_resched()) {
> > rcu_read_unlock();
> > cond_resched();
> > rcu_read_lock();
> > }
> > }
>
> Thanks, looks like a good idea to me, I guess
> its place is include/linux/sched.h. Simon, can you prepare
> 2 patches instead, one for cond_resched_rcu_lock and second
> for ipvs?
Sure, will do.
next prev parent reply other threads:[~2013-04-26 0:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 1:12 [PATCH ipvs-next] ipvs: Remove rcu_read_unlock();rcu_read_lock(); Simon Horman
2013-04-25 8:15 ` Julian Anastasov
2013-04-25 9:05 ` Hans Schillstrom
2013-04-25 13:36 ` Simon Horman
2013-04-25 14:04 ` Eric Dumazet
2013-04-25 19:46 ` Julian Anastasov
2013-04-26 0:28 ` Simon Horman [this message]
2013-04-26 0:59 ` Pablo Neira Ayuso
2013-04-26 6:02 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130426002813.GD29748@verge.net.au \
--to=horms@verge.net.au \
--cc=eric.dumazet@gmail.com \
--cc=hans@schillstrom.com \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).