From: Arturo Borrero <arturo.borrero.glez@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [libnftables PATCH 1/2] src: delete exporting internal flags in XML
Date: Mon, 29 Apr 2013 14:36:07 +0200 [thread overview]
Message-ID: <20130429123607.26114.18073.stgit@nfdev.cica.es> (raw)
The uint32_t flags attribute is internal, so no need to export/import in XML.
Signed-off-by: Arturo Borrero González <arturo.borrero.glez@gmail.com>
---
src/chain.c | 5 ++---
src/table.c | 3 +--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/chain.c b/src/chain.c
index fb5d218..44a0e66 100644
--- a/src/chain.c
+++ b/src/chain.c
@@ -452,7 +452,6 @@ static int nft_chain_snprintf_xml(char *buf, size_t size, struct nft_chain *c)
"<chain name=\"%s\" handle=\"%lu\""
" bytes=\"%lu\" packets=\"%lu\">"
"<properties>"
- "<flags>%d</flags>"
"<type>%s</type>"
"<table>%s</table>"
"<prio>%d</prio>"
@@ -463,8 +462,8 @@ static int nft_chain_snprintf_xml(char *buf, size_t size, struct nft_chain *c)
"</properties>"
"</chain>",
c->name, c->handle, c->bytes, c->packets,
- c->flags, c->type, c->table, c->prio,
- c->use, c->hooknum, c->policy, c->family);
+ c->type, c->table, c->prio, c->use, c->hooknum,
+ c->policy, c->family);
}
static int nft_chain_snprintf_default(char *buf, size_t size, struct nft_chain *c)
diff --git a/src/table.c b/src/table.c
index 2d72136..8adaba8 100644
--- a/src/table.c
+++ b/src/table.c
@@ -188,11 +188,10 @@ static int nft_table_snprintf_xml(char *buf, size_t size, struct nft_table *t)
"<table name=\"%s\">"
"<properties>"
"<family>%u</family>"
- "<flags>%d</flags>"
"<table_flags>%d</table_flags>"
"</properties>"
"</table>" ,
- t->name, t->family, t->flags, t->table_flags);
+ t->name, t->family, t->table_flags);
}
static int nft_table_snprintf_default(char *buf, size_t size, struct nft_table *t)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2013-04-29 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 12:36 Arturo Borrero [this message]
2013-04-29 12:36 ` [libnftables PATCH 2/2] src: support for XML parsing Arturo Borrero
2013-05-03 16:24 ` Pablo Neira Ayuso
2013-05-08 10:36 ` Arturo Borrero Gonzalez
2013-05-08 11:26 ` Arturo Borrero Gonzalez
2013-05-03 16:22 ` [libnftables PATCH 1/2] src: delete exporting internal flags in XML Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130429123607.26114.18073.stgit@nfdev.cica.es \
--to=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).