From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: eric.dumazet@gmail.com, pablo@netfilter.org,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
therbert@google.com, kaber@trash.net
Subject: Re: [PATCH v2 nf-next] netfilter: conntrack: remove the central spinlock
Date: Wed, 22 May 2013 14:29:46 -0700 (PDT) [thread overview]
Message-ID: <20130522.142946.1071765105220112729.davem@davemloft.net> (raw)
In-Reply-To: <1369257171.2143.120.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Wed, 22 May 2013 14:12:51 -0700
> @@ -528,7 +528,7 @@ struct netdev_queue {
> * write mostly part
> */
> spinlock_t _xmit_lock ____cacheline_aligned_in_smp;
> - int xmit_lock_owner;
> + u16 xmit_lock_owner;
> /*
> * please use this field instead of dev->trans_start
> */
> @@ -2453,7 +2453,7 @@ static inline void __netif_tx_unlock_bh(struct netdev_queue *txq)
>
> static inline void txq_trans_update(struct netdev_queue *txq)
> {
> - if (txq->xmit_lock_owner != -1)
> + if (txq->xmit_lock_owner != (u16)-1)
> txq->trans_start = jiffies;
> }
Then technically this is an s16, don't use casts to pretend that it
isn't.
next prev parent reply other threads:[~2013-05-22 21:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 3:04 [PATCH nf-next] netfilter: conntrack: remove the central spinlock Eric Dumazet
2013-05-09 5:43 ` Cong Wang
2013-05-09 6:01 ` Eric Dumazet
2013-05-09 7:46 ` Cong Wang
2013-05-09 13:46 ` Eric Dumazet
2013-05-22 17:47 ` [PATCH v2 " Eric Dumazet
2013-05-22 18:20 ` Joe Perches
2013-05-22 19:26 ` Eric Dumazet
2013-05-22 19:57 ` Joe Perches
2013-05-22 20:16 ` Eric Dumazet
2013-05-22 20:38 ` Joe Perches
2013-05-22 20:48 ` Eric Dumazet
2013-05-22 21:12 ` Joe Perches
2013-05-22 21:29 ` David Miller [this message]
2013-05-22 21:34 ` Eric Dumazet
2013-05-24 13:16 ` Jesper Dangaard Brouer
2013-05-24 13:51 ` Eric Dumazet
2013-05-27 12:33 ` Jesper Dangaard Brouer
2013-05-27 12:36 ` Pablo Neira Ayuso
2013-08-23 14:42 ` Jesper Dangaard Brouer
2013-08-26 22:28 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522.142946.1071765105220112729.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).