From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: jirislaby@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, Jeff Mahoney <jeffm@suse.com>,
Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH -resend 4/6] netfilter: Implement RFC 1123 for FTP conntrack
Date: Mon, 27 May 2013 14:20:33 +0200 [thread overview]
Message-ID: <20130527122033.GA16107@localhost> (raw)
In-Reply-To: <1369227552-11743-4-git-send-email-jslaby@suse.cz>
On Wed, May 22, 2013 at 02:59:10PM +0200, Jiri Slaby wrote:
> From: Jeff Mahoney <jeffm@suse.com>
>
> The FTP conntrack code currently only accepts the following format for
> the 227 response for PASV:
> 227 Entering Passive Mode (148,100,81,40,31,161).
>
> It doesn't accept the following format from an obscure server:
> 227 Data transfer will passively listen to 67,218,99,134,50,144
>
> From RFC 1123:
> The format of the 227 reply to a PASV command is not
> well standardized. In particular, an FTP client cannot
> assume that the parentheses shown on page 40 of RFC-959
> will be present (and in fact, Figure 3 on page 43 omits
> them). Therefore, a User-FTP program that interprets
> the PASV reply must scan the reply for the first digit
> of the host and port numbers.
Applied, thanks.
prev parent reply other threads:[~2013-05-27 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1369227552-11743-1-git-send-email-jslaby@suse.cz>
2013-05-22 12:59 ` [PATCH -resend 4/6] netfilter: Implement RFC 1123 for FTP conntrack Jiri Slaby
2013-05-27 12:20 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130527122033.GA16107@localhost \
--to=pablo@netfilter.org \
--cc=akpm@linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=jeffm@suse.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).