netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Tamas Lengyel <tamas.k.lengyel@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] libnetfilter_queue: Fix Valgrind errors of unitialized byte(s) during call to nfq_unbind_pf
Date: Sat, 1 Jun 2013 11:34:30 +0200	[thread overview]
Message-ID: <20130601093430.GA10925@breakpoint.cc> (raw)
In-Reply-To: <CABfawhm7V6htNehkNrf-pCSsHt-gjZCOgBhAMAoCh7UyY=rapQ@mail.gmail.com>

Tamas Lengyel <tamas.k.lengyel@gmail.com> wrote:
> Valgrind generates error reports of unitialized byte(s) during a call
> to the nfq_unbind_pf function:
> ==00:00:00:08.662 22111== 4 errors in context 1 of 1:
> ==00:00:00:08.662 22111== Syscall param socketcall.sendto(msg) points
> to uninitialised byte(s)

Since the kernel doesn't use this value nothing bad will happen.
But, since __send_cgf_msg is hardly a fastpath I've applied the patch,
thanks.

For your next patch submission, please

> The following (tiny) patch gets rid of the issue. I made the patch
> available on github as well at
> git://github.com/tklengyel/libnetfilter_queue.git

move this snippet
> ---

Here, so that git-am can remove the non-changelog part
automatically.

Also, please send a copy of the patch to yourself
and try to apply the patch yourself with git-am.

Your mailer program mangled the tabs in the patch so it didn't apply
without manual editing.

Thanks.

      reply	other threads:[~2013-06-01  9:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31 22:20 [PATCH] libnetfilter_queue: Fix Valgrind errors of unitialized byte(s) during call to nfq_unbind_pf Tamas Lengyel
2013-06-01  9:34 ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130601093430.GA10925@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=tamas.k.lengyel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).