From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alvaro Neira <alvaroneay@gmail.com>
Cc: netfilter-devel@vger.kernel.org, julien@linuxwall.info
Subject: Re: [libnftables PATCH 3/4] Add JSON Constant for to use the Json export function
Date: Thu, 6 Jun 2013 18:25:58 +0200 [thread overview]
Message-ID: <20130606162558.GA30602@localhost> (raw)
In-Reply-To: <20130606131725.18048.26908.stgit@Ph0enix>
Hi Alvaro,
On Thu, Jun 06, 2013 at 03:17:25PM +0200, Alvaro Neira wrote:
>
> ---
> 0 files changed
>
> diff --git a/include/libnftables/table.h b/include/libnftables/table.h
> index 658230c..19f322c 100644
> --- a/include/libnftables/table.h
> +++ b/include/libnftables/table.h
> @@ -31,6 +31,7 @@ void nft_table_nlmsg_build_payload(struct nlmsghdr *nlh, const struct nft_table
> enum {
> NFT_TABLE_O_DEFAULT = 0,
> NFT_TABLE_O_XML,
> + NFT_TABLE_O_JSON,
you have to collapse patch 1/4, 3/4 and 4/4. You cannot add the
definition of this constant in a follow-up patch. Note that the
repository has to remain consistent between patches, and after patch
1/4, if I compile libnftables, it would break.
Please, fix it and resubmit. Thanks.
next prev parent reply other threads:[~2013-06-06 16:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 13:17 [libnftables PATCH 1/4] Add functions for to export tables to JSON format Alvaro Neira
2013-06-06 13:17 ` [libnftables PATCH 2/4] Add implementation for to proof the JSON export function Alvaro Neira
2013-06-06 13:17 ` [libnftables PATCH 3/4] Add JSON Constant for to use the Json " Alvaro Neira
2013-06-06 16:25 ` Pablo Neira Ayuso [this message]
2013-06-06 13:17 ` [libnftables PATCH 4/4] Add a constant for to put the JSON Version Alvaro Neira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606162558.GA30602@localhost \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=julien@linuxwall.info \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).