From: Arturo Borrero <arturo.borrero.glez@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [libnftables PATCH] data_reg: xml: delete unreachable code in _veredict_xml_parse()
Date: Sat, 08 Jun 2013 16:02:33 +0200 [thread overview]
Message-ID: <20130608140233.2361.71553.stgit@nfdev.cica.es> (raw)
This code was unreachable.
There was a similar commit fixing a similar code which didn't fix this (414ac29).
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
src/expr/data_reg.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c
index a7511a7..5eb7f38 100644
--- a/src/expr/data_reg.c
+++ b/src/expr/data_reg.c
@@ -76,8 +76,6 @@ static int nft_data_reg_verdict_xml_parse(union nft_data_reg *reg, char *xml)
mxmlDelete(tree);
return 0;
- errno = EOPNOTSUPP;
- return -1;
}
static int nft_data_reg_chain_xml_parse(union nft_data_reg *reg, char *xml)
next reply other threads:[~2013-06-08 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 14:02 Arturo Borrero [this message]
2013-06-08 17:25 ` [libnftables PATCH] data_reg: xml: delete unreachable code in _veredict_xml_parse() Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130608140233.2361.71553.stgit@nfdev.cica.es \
--to=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).