* [libnftables PATCH] data_reg: xml: delete unreachable code in _veredict_xml_parse()
@ 2013-06-08 14:02 Arturo Borrero
2013-06-08 17:25 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Arturo Borrero @ 2013-06-08 14:02 UTC (permalink / raw)
To: netfilter-devel; +Cc: pablo
This code was unreachable.
There was a similar commit fixing a similar code which didn't fix this (414ac29).
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
src/expr/data_reg.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c
index a7511a7..5eb7f38 100644
--- a/src/expr/data_reg.c
+++ b/src/expr/data_reg.c
@@ -76,8 +76,6 @@ static int nft_data_reg_verdict_xml_parse(union nft_data_reg *reg, char *xml)
mxmlDelete(tree);
return 0;
- errno = EOPNOTSUPP;
- return -1;
}
static int nft_data_reg_chain_xml_parse(union nft_data_reg *reg, char *xml)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [libnftables PATCH] data_reg: xml: delete unreachable code in _veredict_xml_parse()
2013-06-08 14:02 [libnftables PATCH] data_reg: xml: delete unreachable code in _veredict_xml_parse() Arturo Borrero
@ 2013-06-08 17:25 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-06-08 17:25 UTC (permalink / raw)
To: Arturo Borrero; +Cc: netfilter-devel
On Sat, Jun 08, 2013 at 04:02:33PM +0200, Arturo Borrero wrote:
> This code was unreachable.
>
> There was a similar commit fixing a similar code which didn't fix this (414ac29).
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-08 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-08 14:02 [libnftables PATCH] data_reg: xml: delete unreachable code in _veredict_xml_parse() Arturo Borrero
2013-06-08 17:25 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).