netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Phil Oester <kernel@linuxace.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: Fix connlabel.conf install location
Date: Wed, 12 Jun 2013 11:08:15 +0200	[thread overview]
Message-ID: <20130612090815.GA13356@localhost> (raw)
In-Reply-To: <20130612085037.GA10600@localhost>

On Wed, Jun 12, 2013 at 10:50:37AM +0200, Pablo Neira Ayuso wrote:
> On Wed, Jun 12, 2013 at 09:51:55AM +0200, Florian Westphal wrote:
> > Phil Oester <kernel@linuxace.com> wrote:
> > > As reported by Danny Rawlins in bug #828, connlabel.conf is unconditionally
> > > installed in /etc/xtables instead of using prefix set at configure time.  Fix
> > > to use sysconfdir variable.
> > 
> > It was intentional.
> > I don't want userspace to start guessing where the config file is.
> 
> Sorry Florian, we crossed emails while replying this.
> 
> I think this is still useful for people cross-compiling and installing
> iptables in some custom location.

Hm, still, this may confuse people, as xt_connlabel always looks at:

#define CONNLABEL_CFG "/etc/xtables/connlabel.conf"

  reply	other threads:[~2013-06-12  9:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10  9:35 [PATCH] iptables: Fix connlabel.conf install location Phil Oester
2013-06-12  7:51 ` Florian Westphal
2013-06-12  8:50   ` Pablo Neira Ayuso
2013-06-12  9:08     ` Pablo Neira Ayuso [this message]
2013-06-12 10:06       ` Florian Westphal
2013-06-25 16:01         ` Pablo Neira Ayuso
2013-06-25 19:52           ` Florian Westphal
2013-07-03  0:13             ` Pablo Neira Ayuso
2013-06-12  8:04 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130612090815.GA13356@localhost \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=kernel@linuxace.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).