From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Jesper Dangaard Brouer <brouer@redhat.com>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH nf-next] netfilter: xt_socket: add XT_SOCKET_NOWILDCARD flag
Date: Thu, 20 Jun 2013 11:55:00 +0200 [thread overview]
Message-ID: <20130620095500.GB698@localhost> (raw)
In-Reply-To: <1371717515.3252.392.camel@edumazet-glaptop>
On Thu, Jun 20, 2013 at 01:38:35AM -0700, Eric Dumazet wrote:
> On Mon, 2013-06-03 at 15:57 -0700, Eric Dumazet wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
> > xt_socket module can be a nice replacement to conntrack module
> > in some cases (SYN filtering for example)
> >
> > But it lacks the ability to match the 3rd packet of TCP
> > handshake (ACK coming from the client).
> >
> > Add a XT_SOCKET_NOWILDCARD flag to disable the wildcard mechanism
> >
> > iptables -I INPUT -p tcp --syn -j SYN_CHAIN
> > iptables -I INPUT -m socket -j ACCEPT
> >
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > Cc: Patrick McHardy <kaber@trash.net>
> > Cc: Jesper Dangaard Brouer <brouer@redhat.com>
> > ---
>
> Hi Pablo, is there any problem with this patch ?
user-space part is missing (or at least I didn't manage to find the
patch).
We've been adding new revision for such a changes. I know it's a bit
too much, but we want to make sure that a user does not set this
option from user-space and it's silently ignored by iptables.
next prev parent reply other threads:[~2013-06-20 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 22:57 [PATCH nf-next] netfilter: xt_socket: add XT_SOCKET_NOWILDCARD flag Eric Dumazet
2013-06-04 9:10 ` Jesper Dangaard Brouer
2013-06-04 13:46 ` Eric Dumazet
2013-06-04 14:30 ` Jesper Dangaard Brouer
2013-06-20 8:38 ` Eric Dumazet
2013-06-20 9:55 ` Pablo Neira Ayuso [this message]
2013-06-20 10:19 ` Eric Dumazet
2013-06-20 12:52 ` [PATCH v2 " Eric Dumazet
2013-06-25 0:57 ` Pablo Neira Ayuso
2013-06-20 12:52 ` [PATCH iptables] xt_socket: add --nowildcard flag Eric Dumazet
2013-06-25 0:58 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620095500.GB698@localhost \
--to=pablo@netfilter.org \
--cc=brouer@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).