netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Phil Oester <kernel@linuxace.com>,
	netfilter-devel@vger.kernel.org, kaber@trash.net,
	davem@davemloft.net, security@kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack_ipv6: Plug sk_buff leak in fragment handling
Date: Thu, 20 Jun 2013 11:56:54 +0200	[thread overview]
Message-ID: <20130620095654.GC698@localhost> (raw)
In-Reply-To: <20130620092031.GC2124@breakpoint.cc>

On Thu, Jun 20, 2013 at 11:20:31AM +0200, Florian Westphal wrote:
> Phil Oester <kernel@linuxace.com> wrote:
> > In commit 4cdd3408 ("netfilter: nf_conntrack_ipv6: improve fragmentation
> > handling"), an sk_buff leak was introduced when dealing with reassembled
> > packets by grabbing a reference to the original skb instead of the
> > reassembled skb.  At this point, the leak only impacted conntracks with an
> > associated helper.  
> 
> David, could you please apply this patch directly in case Pablo doesn't
> apply it first?  This fixes a remote DoS, so it better hit -stable ASAP.

I'll take care of it.

      reply	other threads:[~2013-06-20  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19 10:49 [PATCH] netfilter: nf_conntrack_ipv6: Plug sk_buff leak in fragment handling Phil Oester
2013-06-20  9:20 ` Florian Westphal
2013-06-20  9:56   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130620095654.GC698@localhost \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=kaber@trash.net \
    --cc=kernel@linuxace.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=security@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).