From: Phil Oester <kernel@linuxace.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: ip[6]t_REJECT: tcp-reset using wrong MAC source if bridged
Date: Wed, 3 Jul 2013 09:59:20 -0700 [thread overview]
Message-ID: <20130703165920.GA2500@linuxace.com> (raw)
In-Reply-To: <20130702234131.GA8412@localhost>
On Wed, Jul 03, 2013 at 01:41:31AM +0200, Pablo Neira Ayuso wrote:
> > + if (oldskb->nf_bridge) {
> > + struct ethhdr *oeth = eth_hdr(oldskb);
> > + nskb->dev = oldskb->nf_bridge->physindev;
>
> This won't work for locally generated traffic, physindev is null in
> that case.
But nf_bridge is NULL for locally generated traffic, so we won't
even enter this section at all.
Phil
next prev parent reply other threads:[~2013-07-03 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 21:16 [PATCH] netfilter: ip[6]t_REJECT: tcp-reset using wrong MAC source if bridged Phil Oester
2013-07-02 23:41 ` Pablo Neira Ayuso
2013-07-03 16:59 ` Phil Oester [this message]
2013-08-27 22:49 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703165920.GA2500@linuxace.com \
--to=kernel@linuxace.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).