* [PATCH 0/2] minor debugging fixes
@ 2013-07-04 7:26 Alexey Perevalov
2013-07-04 7:26 ` [PATCH 1/2] Clarify DEBUG usage macro Alexey Perevalov
2013-07-04 7:26 ` [PATCH 2/2] extensions: libxt_dccp/libxt_sctp: enable debug tracing by DEBUG define Alexey Perevalov
0 siblings, 2 replies; 4+ messages in thread
From: Alexey Perevalov @ 2013-07-04 7:26 UTC (permalink / raw)
To: netfilter-devel; +Cc: Alexey Perevalov
I faced with inconvenient behaviour in early version of iptables,
it runs modprobe unconditionally. I know it is already fixed.
While debugging I came across to missing debug trace in libxt_dccp and
libxt_sctp. Also I think it would be better to clarify DEBUG define usage.
Alexey Perevalov (2):
Clarify DEBUG usage macro
extensions: libxt_dccp/libxt_sctp: enable debug tracing by DEBUG
define
INSTALL | 2 ++
extensions/libxt_dccp.c | 4 ++--
extensions/libxt_sctp.c | 4 ++--
3 files changed, 6 insertions(+), 4 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/2] Clarify DEBUG usage macro 2013-07-04 7:26 [PATCH 0/2] minor debugging fixes Alexey Perevalov @ 2013-07-04 7:26 ` Alexey Perevalov 2013-07-04 7:26 ` [PATCH 2/2] extensions: libxt_dccp/libxt_sctp: enable debug tracing by DEBUG define Alexey Perevalov 1 sibling, 0 replies; 4+ messages in thread From: Alexey Perevalov @ 2013-07-04 7:26 UTC (permalink / raw) To: netfilter-devel; +Cc: Alexey Perevalov Signed-off-by: Alexey Perevalov <a.perevalov@samsung.com> --- INSTALL | 2 ++ 1 file changed, 2 insertions(+) diff --git a/INSTALL b/INSTALL index e17e844..d62b428 100644 --- a/INSTALL +++ b/INSTALL @@ -70,6 +70,8 @@ If you want to enable debugging, use (-O0 is used to turn off instruction reordering, which makes debugging much easier.) +To show debug traces you can add -DDEBUG to CFLAGS option + Other notes =========== -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] extensions: libxt_dccp/libxt_sctp: enable debug tracing by DEBUG define 2013-07-04 7:26 [PATCH 0/2] minor debugging fixes Alexey Perevalov 2013-07-04 7:26 ` [PATCH 1/2] Clarify DEBUG usage macro Alexey Perevalov @ 2013-07-04 7:26 ` Alexey Perevalov 2013-07-08 2:55 ` Pablo Neira Ayuso 1 sibling, 1 reply; 4+ messages in thread From: Alexey Perevalov @ 2013-07-04 7:26 UTC (permalink / raw) To: netfilter-devel; +Cc: Alexey Perevalov Signed-off-by: Alexey Perevalov <a.perevalov@samsung.com> --- extensions/libxt_dccp.c | 4 ++-- extensions/libxt_sctp.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/extensions/libxt_dccp.c b/extensions/libxt_dccp.c index a35cabb..06cd23d 100644 --- a/extensions/libxt_dccp.c +++ b/extensions/libxt_dccp.c @@ -16,11 +16,11 @@ #include <linux/netfilter/x_tables.h> #include <linux/netfilter/xt_dccp.h> -#if 0 +#ifdef DEBUG #define DEBUGP(format, first...) printf(format, ##first) #define static #else -#define DEBUGP(format, fist...) +#define DEBUGP(format, fist...) #endif enum { diff --git a/extensions/libxt_sctp.c b/extensions/libxt_sctp.c index 56a4cdf..f5959cb 100644 --- a/extensions/libxt_sctp.c +++ b/extensions/libxt_sctp.c @@ -20,11 +20,11 @@ #include <linux/netfilter/xt_sctp.h> -#if 0 +#if DEBUG #define DEBUGP(format, first...) printf(format, ##first) #define static #else -#define DEBUGP(format, fist...) +#define DEBUGP(format, fist...) #endif static void -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] extensions: libxt_dccp/libxt_sctp: enable debug tracing by DEBUG define 2013-07-04 7:26 ` [PATCH 2/2] extensions: libxt_dccp/libxt_sctp: enable debug tracing by DEBUG define Alexey Perevalov @ 2013-07-08 2:55 ` Pablo Neira Ayuso 0 siblings, 0 replies; 4+ messages in thread From: Pablo Neira Ayuso @ 2013-07-08 2:55 UTC (permalink / raw) To: Alexey Perevalov; +Cc: netfilter-devel On Thu, Jul 04, 2013 at 11:26:18AM +0400, Alexey Perevalov wrote: > Signed-off-by: Alexey Perevalov <a.perevalov@samsung.com> > --- > extensions/libxt_dccp.c | 4 ++-- > extensions/libxt_sctp.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/extensions/libxt_dccp.c b/extensions/libxt_dccp.c > index a35cabb..06cd23d 100644 > --- a/extensions/libxt_dccp.c > +++ b/extensions/libxt_dccp.c > @@ -16,11 +16,11 @@ > #include <linux/netfilter/x_tables.h> > #include <linux/netfilter/xt_dccp.h> > > -#if 0 > +#ifdef DEBUG > #define DEBUGP(format, first...) printf(format, ##first) > #define static > #else > -#define DEBUGP(format, fist...) > +#define DEBUGP(format, fist...) > #endif I don't find any client of this code for libxt_dccp, better delete it in that case. > enum { > diff --git a/extensions/libxt_sctp.c b/extensions/libxt_sctp.c > index 56a4cdf..f5959cb 100644 > --- a/extensions/libxt_sctp.c > +++ b/extensions/libxt_sctp.c > @@ -20,11 +20,11 @@ > > #include <linux/netfilter/xt_sctp.h> > > -#if 0 > +#if DEBUG > #define DEBUGP(format, first...) printf(format, ##first) > #define static > #else > -#define DEBUGP(format, fist...) > +#define DEBUGP(format, fist...) > #endif > > static void > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-08 2:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-07-04 7:26 [PATCH 0/2] minor debugging fixes Alexey Perevalov 2013-07-04 7:26 ` [PATCH 1/2] Clarify DEBUG usage macro Alexey Perevalov 2013-07-04 7:26 ` [PATCH 2/2] extensions: libxt_dccp/libxt_sctp: enable debug tracing by DEBUG define Alexey Perevalov 2013-07-08 2:55 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).