netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Bill Fink <billfink@mindspring.com>
Cc: netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: conntrackd segfault on EPSV IPv6 ftp command when using ftp ExpectationSync
Date: Mon, 15 Jul 2013 14:49:05 +0200	[thread overview]
Message-ID: <20130715124905.GA21260@localhost> (raw)
In-Reply-To: <20130712030114.0362fb5a.billfink@mindspring.com>

On Fri, Jul 12, 2013 at 03:01:14AM -0400, Bill Fink wrote:
> Pablo,
> 
> On Thu, 11 Jul 2013, Pablo Neira Ayuso wrote:
> 
> > On Thu, Jul 11, 2013 at 12:08:20AM +0200, Pablo Neira Ayuso wrote:
> > > On Wed, Jul 10, 2013 at 05:58:15AM -0400, Bill Fink wrote:
> > > > Almost there.  With the above patch, I now successfully get
> > > > IPv6 expectations on the backup firewall.  Unfortunately they're
> > > > not quite right.  On the backup firewall, the expectation src-IP
> > > > is the same as the dst-IP (either IPv4 or IPv6).
> > > > 
> > > > Primary firewall:
> > > > 
> > > > [root@sen-fw1 linux-3.7.3-101.fc17.x86_64]# conntrack -L expect
> > > > 251 proto=6 src=192.168.218.199 dst=192.168.28.198 sport=0 dport=54705 mask-src=255.255.255.255 mask-dst=255.255.255.255 sport=0 dport=65535 master-src=192.168.218.199 master-dst=192.168.28.198 sport=56877 dport=21 class=0 helper=ftp
> > > > conntrack v1.4.0 (conntrack-tools): 1 expectations have been shown.
> > > > 
> > > > Backup firewall:
> > > > 
> > > > [root@sen-fw2 linux-3.7.3-101.fc17.x86_64]# conntrack -L expect
> > > > 245 proto=6 src=192.168.28.198 dst=192.168.28.198 sport=0 dport=54705 mask-src=255.255.255.255 mask-dst=255.255.255.255 sport=0 dport=65535 master-src=192.168.218.199 master-dst=192.168.28.198 sport=56877 dport=21 class=0 helper=ftp
> > > > conntrack v1.4.0 (conntrack-tools): 1 expectations have been shown.
> > > > 
> > > > This was an unfortunate side affect of the patch to fix the
> > > > conntrackd segfault problem.  If I use Florian's version
> > > > of the fix segfault patch rather than Pablo's then all is
> > > > good.
> > > 
> > > Thanks for the information, however, we still need to get working back
> > > the filtering support.
> > > 
> > > Could you give a try to the following patch, please?
> > > 
> > > It applies on top of conntrack-tools master branch, thanks.
> > 
> > There are still some downsides in the previous solution, please, give
> > a try to this patch instead.
> 
> It appears to work pretty well and does fix the src-IP issue!

Thanks for testing and reporting back, I have pushed the patch to
master.

> I did notice a couple of other things but they're not necessarily
> related to these patches.  I noticed that my long lived BGP tcp
> connection was getting some duplicate conntrackd ct entries (both
> IPv4 and IPv6).  The duplicate ct entry occurred 60 seconds after
> the original, and once I saw a second duplicate ct IPv4 entry,
> again with about a 60 second separation.

That's strange. Please, tell me if this happening in the primary
and/or the backup. If you are using the cache mode, also dump the
caches via -i and -e to see the content.

> And on the expectation entries, they seem to have a lifetime
> of 300 seconds.  The IPv6 expectation entries are deleted after
> the 300 seconds as expected, but the IPv4 expectation entries
> actually go away in a minute or less.  I don't know if that
> is expected behavior or not.  Note I was leaving the ftp
> control connection open the entire time.  Also it may have
> just been my imagination, but it seemed if I queried it more
> often with "conntrack -L expect" it would stick around somewhat
> longer (but would go away within the minute).

Expectations depends on the master conntrack, if the master is
released, the expectations will be released too. You may be noticing
that effect.

You can use `conntrack -E` and `conntrack -E exp` to verify this.

Regards.

  reply	other threads:[~2013-07-15 12:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05  6:03 conntrackd segfault on EPSV IPv6 ftp command when using ftp ExpectationSync Bill Fink
2013-07-05  8:19 ` Florian Westphal
2013-07-05 19:45 ` Bill Fink
2013-07-05 23:52   ` Bill Fink
2013-07-06 13:23 ` Pablo Neira Ayuso
2013-07-07  7:04   ` Bill Fink
2013-07-09  5:30     ` Bill Fink
2013-07-09 18:22       ` Pablo Neira Ayuso
2013-07-10  9:58         ` Bill Fink
2013-07-10 22:08           ` Pablo Neira Ayuso
2013-07-11  0:48             ` Pablo Neira Ayuso
2013-07-11 15:19               ` Bill Fink
2013-07-12  7:01               ` Bill Fink
2013-07-15 12:49                 ` Pablo Neira Ayuso [this message]
2013-07-16  5:55                   ` Bill Fink
2013-07-16 21:33                     ` Pablo Neira Ayuso
2013-07-16 21:37                       ` Pablo Neira Ayuso
2013-07-22  7:00                       ` Bill Fink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130715124905.GA21260@localhost \
    --to=pablo@netfilter.org \
    --cc=billfink@mindspring.com \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).