From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables-nftables - PATCH 2/2] nft: Fix code style issues
Date: Wed, 17 Jul 2013 15:47:42 +0200 [thread overview]
Message-ID: <20130717134742.GA7940@localhost> (raw)
In-Reply-To: <1374046455-19234-3-git-send-email-tomasz.bursztyka@linux.intel.com>
I don't feel like taking this at this moment.
I think many of those style adjustments could be fixed by splitting
functions into smaller chunks and with several helper functions
similar to your "nft: add function to test for a builtin chain" patch,
which I think is the way to go to get this code better.
We can also revisit this later if you don't want to work on this at
this moment.
Thanks for the patch in any case.
next prev parent reply other threads:[~2013-07-17 13:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 7:34 [iptables-nftables - PATCH 0/2] fixes Tomasz Bursztyka
2013-07-17 7:34 ` [iptables-nftables - PATCH 1/2] nft: Optimize chain listing if only one is looked for Tomasz Bursztyka
2013-07-17 13:40 ` Pablo Neira Ayuso
2013-07-18 11:10 ` Tomasz Bursztyka
2013-07-17 7:34 ` [iptables-nftables - PATCH 2/2] nft: Fix code style issues Tomasz Bursztyka
2013-07-17 13:47 ` Pablo Neira Ayuso [this message]
2013-07-18 11:12 ` Tomasz Bursztyka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717134742.GA7940@localhost \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=tomasz.bursztyka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).