Linux Netfilter development
 help / color / mirror / Atom feed
From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
To: netfilter-devel@vger.kernel.org
Subject: [libnftables PATCH] immediate: xml: fix name inconsistency
Date: Thu, 25 Jul 2013 22:54:11 +0200	[thread overview]
Message-ID: <20130725205411.22962.57274.stgit@nfdev.cica.es> (raw)

<immdata> must be <immediatedata>.

This bug was introduced at (1e8e5d4 src: xml: consolidate parsing of data_reg via nft_mxml_data_reg_parse).

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/expr/immediate.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/expr/immediate.c b/src/expr/immediate.c
index 48e9d1e..e65bd7c 100644
--- a/src/expr/immediate.c
+++ b/src/expr/immediate.c
@@ -192,7 +192,8 @@ nft_rule_expr_immediate_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree)
 	imm->dreg = reg;
 	e->flags |= (1 << NFT_EXPR_IMM_DREG);
 
-	datareg_type = nft_mxml_data_reg_parse(tree, "immdata", &imm->data);
+	datareg_type = nft_mxml_data_reg_parse(tree, "immediatedata",
+					       &imm->data);
 	if (datareg_type < 0)
 		return -1;
 


             reply	other threads:[~2013-07-25 20:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 20:54 Arturo Borrero Gonzalez [this message]
2013-07-25 20:58 ` [libnftables PATCH] immediate: xml: fix name inconsistency Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130725205411.22962.57274.stgit@nfdev.cica.es \
    --to=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox