From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/5] netfilter: nf_nat: fix locking in nf_nat_seq_adjust()
Date: Wed, 31 Jul 2013 19:57:37 +0200 [thread overview]
Message-ID: <20130731175737.GA6212@localhost> (raw)
In-Reply-To: <20130731174943.GA8033@macbook.localnet>
On Wed, Jul 31, 2013 at 07:51:18PM +0200, Patrick McHardy wrote:
> On Wed, Jul 31, 2013 at 06:55:23PM +0200, Pablo Neira Ayuso wrote:
> > On Sun, Jul 28, 2013 at 10:54:09PM +0200, Patrick McHardy wrote:
> > > nf_nat_seq_adjust() needs to grab nf_nat_setofs_lock to protect against
> > > concurrent changes to the sequence adjustment data.
> >
> > Applied, thanks.
> >
> > I have enqueued this to nf so it hits 3.11. I have to wait to take 4/5
> > and 5/5 for a while until this patch hits Linus tree.
>
> We've had this problem since the beginning of netfilter, so I think
> this can go to -next. So far I haven't seen any bugreports related to
> this, but its clearly wrong.
Fair enough, will enqueue this to -next then.
> A follow up patch will move the entire sequence number adjustment data
> to an extend, so the size increase will only affect the quite rare case
> of connections using a helper.
Great to know, thanks.
next prev parent reply other threads:[~2013-07-31 17:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 20:54 [PATCH 0/5] netfilter: NAT sequence number adjustment fixes/improvements Patrick McHardy
2013-07-28 20:54 ` [PATCH 1/5] netfilter: nf_conntrack: remove net_ratelimit() for LOG_INVALID() Patrick McHardy
2013-07-31 16:53 ` Pablo Neira Ayuso
2013-07-28 20:54 ` [PATCH 2/5] netfilter: nf_conntrack: constify sk_buff argument to nf_ct_attach() Patrick McHardy
2013-07-31 16:53 ` Pablo Neira Ayuso
2013-07-28 20:54 ` [PATCH 3/5] netfilter: nf_nat: fix locking in nf_nat_seq_adjust() Patrick McHardy
2013-07-31 16:55 ` Pablo Neira Ayuso
2013-07-31 17:51 ` Patrick McHardy
2013-07-31 17:57 ` Pablo Neira Ayuso [this message]
2013-07-28 20:54 ` [PATCH 4/5] netfilter: nf_nat: change sequence number adjustments to 32 bits Patrick McHardy
2013-07-31 17:58 ` Pablo Neira Ayuso
2013-07-28 20:54 ` [PATCH 5/5] netfilter: nf_nat: use per-conntrack locking for sequence number adjustments Patrick McHardy
2013-07-31 17:59 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731175737.GA6212@localhost \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox