From: Simon Horman <horms@verge.net.au>
To: Dragos Foianu <dragos.foianu@gmail.com>
Cc: wensong@linux-vs.org, linux-kernel@vger.kernel.org,
coreteam@netfilter.org, netfilter@vger.kernel.org,
netfilter-devel@vger.kernel.org, lvs-devel@vger.kernel.org,
netdev@vger.kernel.org, davem@davemloft.net,
kadlec@blackhole.kfki.hu, kaber@trash.net, pablo@netfilter.org,
ja@ssi.bg
Subject: Re: [PATCH] ipvs: fixed spacing at for statements
Date: Tue, 6 Aug 2013 15:12:17 +0900 [thread overview]
Message-ID: <20130806061217.GD18246@verge.net.au> (raw)
In-Reply-To: <1373525142-9099-1-git-send-email-dragos.foianu@gmail.com>
On Thu, Jul 11, 2013 at 09:45:42AM +0300, Dragos Foianu wrote:
> found using checkpatch.pl
This seems reasonable to me. I will queue it up in the ipvs-next tree.
>
> Signed-off-by: Dragos Foianu <dragos.foianu@gmail.com>
> ---
> net/netfilter/ipvs/ip_vs_lblcr.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_lblcr.c b/net/netfilter/ipvs/ip_vs_lblcr.c
> index 3cd85b2..5199448 100644
> --- a/net/netfilter/ipvs/ip_vs_lblcr.c
> +++ b/net/netfilter/ipvs/ip_vs_lblcr.c
> @@ -414,7 +414,7 @@ static void ip_vs_lblcr_flush(struct ip_vs_service *svc)
>
> spin_lock_bh(&svc->sched_lock);
> tbl->dead = 1;
> - for (i=0; i<IP_VS_LBLCR_TAB_SIZE; i++) {
> + for (i = 0; i < IP_VS_LBLCR_TAB_SIZE; i++) {
> hlist_for_each_entry_safe(en, next, &tbl->bucket[i], list) {
> ip_vs_lblcr_free(en);
> }
> @@ -440,7 +440,7 @@ static inline void ip_vs_lblcr_full_check(struct ip_vs_service *svc)
> struct ip_vs_lblcr_entry *en;
> struct hlist_node *next;
>
> - for (i=0, j=tbl->rover; i<IP_VS_LBLCR_TAB_SIZE; i++) {
> + for (i = 0, j = tbl->rover; i < IP_VS_LBLCR_TAB_SIZE; i++) {
> j = (j + 1) & IP_VS_LBLCR_TAB_MASK;
>
> spin_lock(&svc->sched_lock);
> @@ -495,7 +495,7 @@ static void ip_vs_lblcr_check_expire(unsigned long data)
> if (goal > tbl->max_size/2)
> goal = tbl->max_size/2;
>
> - for (i=0, j=tbl->rover; i<IP_VS_LBLCR_TAB_SIZE; i++) {
> + for (i = 0, j = tbl->rover; i < IP_VS_LBLCR_TAB_SIZE; i++) {
> j = (j + 1) & IP_VS_LBLCR_TAB_MASK;
>
> spin_lock(&svc->sched_lock);
> @@ -536,7 +536,7 @@ static int ip_vs_lblcr_init_svc(struct ip_vs_service *svc)
> /*
> * Initialize the hash buckets
> */
> - for (i=0; i<IP_VS_LBLCR_TAB_SIZE; i++) {
> + for (i = 0; i < IP_VS_LBLCR_TAB_SIZE; i++) {
> INIT_HLIST_HEAD(&tbl->bucket[i]);
> }
> tbl->max_size = IP_VS_LBLCR_TAB_SIZE*16;
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-08-06 6:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 6:45 [PATCH] ipvs: fixed spacing at for statements Dragos Foianu
2013-08-06 6:12 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130806061217.GD18246@verge.net.au \
--to=horms@verge.net.au \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dragos.foianu@gmail.com \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).