From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 6/7] netfilter: conntrack: don't send destroy events from iterator
Date: Fri, 9 Aug 2013 12:08:34 +0200 [thread overview]
Message-ID: <20130809100834.GA7670@localhost> (raw)
In-Reply-To: <20130731204359.GA27170@breakpoint.cc>
On Wed, Jul 31, 2013 at 10:43:59PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Mon, Jul 29, 2013 at 03:41:55PM +0200, Florian Westphal wrote:
> > > Let nf_ct_delete handle delivery of the DESTROY event.
> > >
> > > This means we now also no longer send such events for conntracks that
> > > are still unconfirmed.
> >
> > Not sure why this happens by looking at the patch. Are you refering to
> > conntrack with IPS_CONFIRMED unset?
>
> Doh. You are right of course.
>
> get_next_corpse also iterates over the unconfirmed list, and ivokes
> iter() for those (and iter is kill_report() which calls
> nf_conntrack_event_report()).
>
> But nf_conntrack_event_report() just returns in !IPS_CONFIRMED case.
>
> Thanks for pointing it out.
Removed that line from the description and applied this patch. Thanks Florian.
next prev parent reply other threads:[~2013-08-09 10:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 13:41 [PATCH 0/7 -next] rm tproxy_core, ct event redelivery via workqueue Florian Westphal
2013-07-29 13:41 ` [PATCH 1/7] netfilter: connlabels: remove unneeded includes Florian Westphal
2013-07-31 16:56 ` Pablo Neira Ayuso
2013-07-29 13:41 ` [PATCH 2/7] netfilter: nf_queue: relax NFQA_CT attribute check Florian Westphal
2013-07-31 16:56 ` Pablo Neira Ayuso
2013-07-29 13:41 ` [PATCH 3/7] netfilter: tproxy: remove nf_tproxy_core, keep tw sk assigned to skb Florian Westphal
2013-07-31 16:57 ` Pablo Neira Ayuso
2013-07-29 13:41 ` [PATCH 4/7] netfilter: tproxy: remove nf_tproxy_core.h Florian Westphal
2013-07-31 16:58 ` Pablo Neira Ayuso
2013-07-29 13:41 ` [PATCH 5/7] netfilter: conntrack: remove duplicate code in conntrack_netlink Florian Westphal
2013-07-31 16:58 ` Pablo Neira Ayuso
2013-07-29 13:41 ` [PATCH 6/7] netfilter: conntrack: don't send destroy events from iterator Florian Westphal
2013-07-31 17:04 ` Pablo Neira Ayuso
2013-07-31 20:43 ` Florian Westphal
2013-08-09 10:08 ` Pablo Neira Ayuso [this message]
2013-07-29 13:41 ` [PATCH 7/7] netfilter: conntrack: remove timer from ecache extension Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809100834.GA7670@localhost \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox