From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alexey Perevalov <a.perevalov@samsung.com>
Cc: netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org
Subject: Re: [PATCH 0/4] Generalize DEBUGP macros
Date: Fri, 9 Aug 2013 17:48:09 +0200 [thread overview]
Message-ID: <20130809154809.GA5147@localhost> (raw)
In-Reply-To: <1374744229-5427-1-git-send-email-a.perevalov@samsung.com>
Hi Alexey,
On Thu, Jul 25, 2013 at 01:23:45PM +0400, Alexey Perevalov wrote:
> It's better to have one common header for keeping debug macro.
> There are many files currently define they own trace macros (DEBUGP).
> All of them are moved to DEBUGP from trace.h.
I commented this with Jozsef, and I think that debugging enabled
everywhere actually makes debugging harder that using selective
debugging, as you may get debug messages that you don't actually want.
Another alternative can be delete many of those DEBUGP, as I think
they are useless these days.
Regards.
prev parent reply other threads:[~2013-08-09 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 9:23 [PATCH 0/4] Generalize DEBUGP macros Alexey Perevalov
2013-07-25 9:23 ` [PATCH 1/4] iptables: Introduce header for keeping debug and trace entities Alexey Perevalov
2013-07-25 9:23 ` [PATCH 2/4] extensions: Use DEBUGP macro from trace.h Alexey Perevalov
2013-07-25 9:23 ` [PATCH 3/4] iptables: " Alexey Perevalov
2013-07-25 9:23 ` [PATCH 4/4] libiptc: " Alexey Perevalov
2013-08-09 15:48 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809154809.GA5147@localhost \
--to=pablo@netfilter.org \
--cc=a.perevalov@samsung.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).