From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alvaro Neira <alvaroneay@gmail.com>
Cc: netfilter-devel@vger.kernel.org, eric@regit.org
Subject: Re: [libnftables PATCH 2/2] test: compare content parsing with original file content.
Date: Sun, 11 Aug 2013 09:47:13 +0200 [thread overview]
Message-ID: <20130811074713.GA3864@localhost> (raw)
In-Reply-To: <20130810194051.18629.33864.stgit@Ph0enix>
On Sat, Aug 10, 2013 at 09:40:51PM +0200, Alvaro Neira wrote:
> From: Álvaro Neira Ayuso <alvaroneay@gmail.com>
>
> Before, we have tested only if we have parsed some file but we
> hadn't tested if the content is OK. Now, we can test if we can
> parse some file and if the object's info is the same than the
> content in the test files.
Applied this minor glitches, see below.
> diff --git a/tests/nft-parsing-test.c b/tests/nft-parsing-test.c
> index e111fd0..f9cfcdf 100644
> --- a/tests/nft-parsing-test.c
> +++ b/tests/nft-parsing-test.c
[...]
> + printf("matching %s: ", filename);
renamed this to "validating" instead of matching.
> + printf("\033[31mFAILED\e[0m (%s)\n", strerror(errno));
removed strerr there. If validation fails, ie. strcmp(original,
output) are not equal, errno does not contain any relevant
information.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-08-11 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 19:40 [libnftables PATCH 1/2] src: expr: use the function base2str in payload Alvaro Neira
2013-08-10 19:40 ` [libnftables PATCH 2/2] test: compare content parsing with original file content Alvaro Neira
2013-08-11 7:47 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130811074713.GA3864@localhost \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=eric@regit.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).