netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [libnftables PATCH] xml: expr: limit: fix wrong assignation when parsing
@ 2013-08-12  7:35 Arturo Borrero Gonzalez
  2013-08-12  9:35 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Arturo Borrero Gonzalez @ 2013-08-12  7:35 UTC (permalink / raw)
  To: netfilter-devel

This assignation was wrong.

Introduced at commit e13819c
(src: xml: consolidate common XML code via nft_mxml_num_parse).


Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 0 files changed

diff --git a/src/expr/limit.c b/src/expr/limit.c
index 9f20c38..336bdb0 100644
--- a/src/expr/limit.c
+++ b/src/expr/limit.c
@@ -130,7 +130,7 @@ static int nft_rule_expr_limit_xml_parse(struct nft_rule_expr *e, mxml_node_t *t
 	e->flags |= (1 << NFT_EXPR_LIMIT_RATE);
 
 	if (nft_mxml_num_parse(tree, "depth", MXML_DESCEND_FIRST, BASE_DEC,
-			       &limit->rate, NFT_TYPE_U64) != 0)
+			       &limit->depth, NFT_TYPE_U64) != 0)
 		return -1;
 
 	e->flags |= (1 << NFT_EXPR_LIMIT_DEPTH);


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [libnftables PATCH] xml: expr: limit: fix wrong assignation when parsing
  2013-08-12  7:35 [libnftables PATCH] xml: expr: limit: fix wrong assignation when parsing Arturo Borrero Gonzalez
@ 2013-08-12  9:35 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-08-12  9:35 UTC (permalink / raw)
  To: Arturo Borrero Gonzalez; +Cc: netfilter-devel

On Mon, Aug 12, 2013 at 09:35:23AM +0200, Arturo Borrero Gonzalez wrote:
> This assignation was wrong.
> 
> Introduced at commit e13819c
> (src: xml: consolidate common XML code via nft_mxml_num_parse).

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-12  9:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-12  7:35 [libnftables PATCH] xml: expr: limit: fix wrong assignation when parsing Arturo Borrero Gonzalez
2013-08-12  9:35 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).