* [libnftables PATCH] utils: fix error path for nft_strtoi
@ 2013-08-19 12:37 Arturo Borrero Gonzalez
2013-08-20 11:09 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Arturo Borrero Gonzalez @ 2013-08-19 12:37 UTC (permalink / raw)
To: netfilter-devel
If the return of nft_get_value() is not evaluated, we don't know if the parsed
value is between the limits of his type.
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
0 files changed
diff --git a/src/utils.c b/src/utils.c
index 848eba9..9a0bcfe 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -103,6 +103,7 @@ int nft_get_value(enum nft_type type, void *val, void *out)
int nft_strtoi(const char *string, int base, void *out, enum nft_type type)
{
+ int ret;
int64_t sval = 0;
uint64_t uval = -1;
char *endptr;
@@ -113,14 +114,14 @@ int nft_strtoi(const char *string, int base, void *out, enum nft_type type)
case NFT_TYPE_U32:
case NFT_TYPE_U64:
uval = strtoll(string, &endptr, base);
- nft_get_value(type, &uval, out);
+ ret = nft_get_value(type, &uval, out);
break;
case NFT_TYPE_S8:
case NFT_TYPE_S16:
case NFT_TYPE_S32:
case NFT_TYPE_S64:
sval = strtoull(string, &endptr, base);
- nft_get_value(type, &sval, out);
+ ret = nft_get_value(type, &sval, out);
break;
default:
errno = EINVAL;
@@ -132,7 +133,7 @@ int nft_strtoi(const char *string, int base, void *out, enum nft_type type)
return -1;
}
- return 0;
+ return ret;
}
const char *nft_verdict2str(uint32_t verdict)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [libnftables PATCH] utils: fix error path for nft_strtoi
2013-08-19 12:37 [libnftables PATCH] utils: fix error path for nft_strtoi Arturo Borrero Gonzalez
@ 2013-08-20 11:09 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-08-20 11:09 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: netfilter-devel
On Mon, Aug 19, 2013 at 02:37:30PM +0200, Arturo Borrero Gonzalez wrote:
> If the return of nft_get_value() is not evaluated, we don't know if
> the parsed value is between the limits of his type.
Applied, thanks Arturo.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-20 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-19 12:37 [libnftables PATCH] utils: fix error path for nft_strtoi Arturo Borrero Gonzalez
2013-08-20 11:09 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).