From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] src: allow to specify the base chain type
Date: Tue, 27 Aug 2013 00:37:32 +0200 [thread overview]
Message-ID: <20130826223732.GA4031@localhost> (raw)
In-Reply-To: <52171199.5090700@linux.intel.com>
On Fri, Aug 23, 2013 at 10:39:05AM +0300, Tomasz Bursztyka wrote:
[...]
> > add table mangle
> > add chain mangle OUTPUT { type route hook NF_INET_LOCAL_OUT 0; }
>
> Instead of NF_INET_LOCAL_OUT could we get OUT? (not literally ;) )
makes sense.
> IN, OUT, PRE-ROUTING, FORWARD, POST-ROUTING etc...
I prefer: input, output, prerouting, forward, postrouting.
> And depending on chain's family, nft would use the right value there
> (IN: is NF_INET_LOCAL_IN for ipv4, NF_ARP_IN for arp, etc...)
>
> It would also make command line easier and more readable.
>
> One more debatable:
> What about adding prio keyword? So it would be { type <string> hook
> <string> prio <num> }
> Or keeping both possibility <num> or prio <num>?
it also makes sense to me, but that should come in a separated patch.
> I can prepare a patch if you want,
Go ahead. Thanks.
prev parent reply other threads:[~2013-08-26 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 15:26 [PATCH nft] src: allow to specify the base chain type Pablo Neira Ayuso
2013-08-23 7:39 ` Tomasz Bursztyka
2013-08-26 22:37 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826223732.GA4031@localhost \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=tomasz.bursztyka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).