From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
mph@one.com, as@one.com
Subject: Re: [nf-next PATCH] netfilter: Extend SYNPROXY with a --continue option
Date: Thu, 29 Aug 2013 10:23:58 +0200 [thread overview]
Message-ID: <20130829102358.4f93ee24@redhat.com> (raw)
In-Reply-To: <20130828160038.GA25799@macbook.localnet>
On Wed, 28 Aug 2013 18:00:42 +0200
Patrick McHardy <kaber@trash.net> wrote:
> On Wed, Aug 28, 2013 at 05:26:55PM +0200, Jesper Dangaard Brouer wrote:
> > Packets reaching SYNPROXY are default dropped, as they are most likely
> > invalid (given the state matching). In other configurations it might
> > be beneficial to let packet not consumed by SYNPROXY (SYN and ACK) to
> > continue being processed by the stack.
> >
> > Introducing a --continue option/flag for the SYNPROXY target to allow
> > these unmatched packets to continue being processed. This would also
> > help in debugging the module via LOG.
>
> I don't think we should add an option for this. Just DROP packets consumed
> by the target and have the other ones continue.
I agree. I'll send a new patch, defaulting to XT_CONTINUE.
Self:
Nacked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
prev parent reply other threads:[~2013-08-29 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 15:26 [nf-next PATCH] netfilter: Extend SYNPROXY with a --continue option Jesper Dangaard Brouer
2013-08-28 16:00 ` Patrick McHardy
2013-08-29 8:23 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829102358.4f93ee24@redhat.com \
--to=brouer@redhat.com \
--cc=as@one.com \
--cc=kaber@trash.net \
--cc=mph@one.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).