From: David Miller <davem@davemloft.net>
To: kernel@linuxace.com
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
eric.dumazet@gmail.com, pablo@netfilter.org
Subject: Re: [PATCH] tcp: tcp_make_synack() should use sock_wmalloc
Date: Fri, 30 Aug 2013 16:03:32 -0400 (EDT) [thread overview]
Message-ID: <20130830.160332.1978667608563540935.davem@davemloft.net> (raw)
In-Reply-To: <20130827234140.GA3301@linuxace.com>
From: Phil Oester <kernel@linuxace.com>
Date: Tue, 27 Aug 2013 16:41:40 -0700
> In commit 90ba9b19 (tcp: tcp_make_synack() can use alloc_skb()), Eric changed
> the call to sock_wmalloc in tcp_make_synack to alloc_skb. In doing so,
> the netfilter owner match lost its ability to block the SYNACK packet on
> outbound listening sockets. Revert the change, restoring the owner match
> functionality.
>
> This closes netfilter bugzilla #847.
>
> Signed-off-by: Phil Oester <kernel@linuxace.com>
Applied and queued up for -stable, thanks.
Eric, I guess if you really want to get rid of the wmem atomics you
can just attach the socket and make a special destructor. Maybe it
is not even worth it at that point however.
prev parent reply other threads:[~2013-08-30 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 23:41 [PATCH] tcp: tcp_make_synack() should use sock_wmalloc Phil Oester
2013-08-30 20:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830.160332.1978667608563540935.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kernel@linuxace.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).