From: Florian Westphal <fw@strlen.de>
To: Phil Oester <kernel@linuxace.com>
Cc: valentina.giusti@bmw-carit.de, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] [RFC] xt_owner: enable xt_owner on INPUT chain
Date: Fri, 30 Aug 2013 17:08:37 +0200 [thread overview]
Message-ID: <20130830150837.GN32493@breakpoint.cc> (raw)
In-Reply-To: <20130830145437.GA7648@linuxace.com>
Phil Oester <kernel@linuxace.com> wrote:
> On Fri, Aug 30, 2013 at 02:43:42PM +0200, valentina.giusti@bmw-carit.de wrote:
> > I'm working on getting the owner extension also on the INPUT chain.
> >
> > In the meanwhile, could anybody please give feedback and tell me if this is the
> > right direction?
>
> What about the (common) case of no local socket? I think that's why the owner
> match was restricted to output|postrouting in the first place, no?
No, it was restricted because skb->sk is only set for locally generated
outgoing packets. As Valentina explained, with tcp early demux skb->sk
will already be set for incoming tcp packets when the packet traverses
the INPUT chain.
prev parent reply other threads:[~2013-08-30 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 12:43 [PATCH] [RFC] xt_owner: enable xt_owner on INPUT chain valentina.giusti
2013-08-30 12:43 ` [PATCH] " valentina.giusti
2013-09-04 12:34 ` Pablo Neira Ayuso
2013-09-04 12:58 ` Valentina Giusti
2013-08-30 14:54 ` [PATCH] [RFC] " Phil Oester
2013-08-30 15:08 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830150837.GN32493@breakpoint.cc \
--to=fw@strlen.de \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=valentina.giusti@bmw-carit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).