netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Giuseppe Longo <giuseppelng@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables-nftables PATCH] nft: refactoring parse operations for more genericity
Date: Sat, 31 Aug 2013 00:31:41 +0200	[thread overview]
Message-ID: <20130830222928.GA9725@localhost> (raw)
In-Reply-To: <1377869753-9093-1-git-send-email-giuseppelng@gmail.com>

Hi Giuseppe,

On Fri, Aug 30, 2013 at 03:35:53PM +0200, Giuseppe Longo wrote:
> This will allow reusing nft_parse_* function for other family than IPv4
> or IPv6.

I like that you send me patches to prepare the arptables support, but
it seems to break things. If I run:

xtables -I INPUT -s 1.1.1.1/32 -d 2.2.2.2/32 -j LOG

the xtables-save says:

-A INPUT -s 1.1.1.1/32 -d 2.2.2.2/32

Note the missing -j target.

Please, fix and resend.

  reply	other threads:[~2013-08-30 22:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 13:35 [iptables-nftables PATCH] nft: refactoring parse operations for more genericity Giuseppe Longo
2013-08-30 22:31 ` Pablo Neira Ayuso [this message]
2013-09-02  9:26 ` Tomasz Bursztyka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130830222928.GA9725@localhost \
    --to=pablo@netfilter.org \
    --cc=giuseppelng@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).