From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, mph@one.com, jesper.brouer@gmail.com
Subject: Re: [PATCH] netfilter: SYNPROXY core: fix warning in __nf_ct_ext_add_length()
Date: Wed, 4 Sep 2013 14:57:09 +0200 [thread overview]
Message-ID: <20130904125709.GC4520@localhost> (raw)
In-Reply-To: <1377765129-8490-1-git-send-email-kaber@trash.net>
On Thu, Aug 29, 2013 at 10:32:09AM +0200, Patrick McHardy wrote:
> With CONFIG_NETFILTER_DEBUG we get the following warning during SYNPROXY init:
>
> [ 80.558906] WARNING: CPU: 1 PID: 4833 at net/netfilter/nf_conntrack_extend.c:80 __nf_ct_ext_add_length+0x217/0x220 [nf_conntrack]()
>
> The reason is that the conntrack template is set to confirmed before adding
> the extension and it is invalid to add extensions to already confirmed
> conntracks. Fix by adding the extensions before setting the conntrack to
> confirmed.
applied, thanks Patrick.
prev parent reply other threads:[~2013-09-04 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 8:32 [PATCH] netfilter: SYNPROXY core: fix warning in __nf_ct_ext_add_length() Patrick McHardy
2013-08-29 10:38 ` Jesper Dangaard Brouer
2013-09-04 12:56 ` Pablo Neira Ayuso
2013-09-04 12:57 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904125709.GC4520@localhost \
--to=pablo@netfilter.org \
--cc=jesper.brouer@gmail.com \
--cc=kaber@trash.net \
--cc=mph@one.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).