* [PATCH] netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet
@ 2013-09-01 15:32 Phil Oester
2013-09-04 12:57 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Phil Oester @ 2013-09-01 15:32 UTC (permalink / raw)
To: netfilter-devel; +Cc: pablo
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
In commit b396966c4 (netfilter: xt_TCPMSS: Fix missing fragmentation handling),
I attempted to add safe fragment handling to xt_TCPMSS. However, Andy Padavan
of Project N56U correctly points out that returning XT_CONTINUE in this
function does not work. The callers (tcpmss_tg[46]) expect to receive a value
of 0 in order to return XT_CONTINUE.
Signed-off-by: Phil Oester <kernel@linuxace.com>
[-- Attachment #2: patch-tcpmss-frag --]
[-- Type: text/plain, Size: 396 bytes --]
diff --git a/net/netfilter/xt_TCPMSS.c b/net/netfilter/xt_TCPMSS.c
index 6113cc7..cd24290 100644
--- a/net/netfilter/xt_TCPMSS.c
+++ b/net/netfilter/xt_TCPMSS.c
@@ -60,7 +60,7 @@ tcpmss_mangle_packet(struct sk_buff *skb,
/* This is a fragment, no TCP header is available */
if (par->fragoff != 0)
- return XT_CONTINUE;
+ return 0;
if (!skb_make_writable(skb, skb->len))
return -1;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet
2013-09-01 15:32 [PATCH] netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet Phil Oester
@ 2013-09-04 12:57 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-09-04 12:57 UTC (permalink / raw)
To: Phil Oester; +Cc: netfilter-devel
On Sun, Sep 01, 2013 at 08:32:21AM -0700, Phil Oester wrote:
> In commit b396966c4 (netfilter: xt_TCPMSS: Fix missing fragmentation handling),
> I attempted to add safe fragment handling to xt_TCPMSS. However, Andy Padavan
> of Project N56U correctly points out that returning XT_CONTINUE in this
> function does not work. The callers (tcpmss_tg[46]) expect to receive a value
> of 0 in order to return XT_CONTINUE.
Applied, thanks Phil.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-04 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-01 15:32 [PATCH] netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet Phil Oester
2013-09-04 12:57 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).