* [libnftables PATCH] set: xml: fix key_type parsing
@ 2013-09-04 16:03 Arturo Borrero Gonzalez
2013-09-05 8:53 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Arturo Borrero Gonzalez @ 2013-09-04 16:03 UTC (permalink / raw)
To: netfilter-devel
Bug introduced by myself at 44928cd5 [set: add XML parsing]
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
0 files changed
diff --git a/src/set.c b/src/set.c
index 1168b54..fe30e77 100644
--- a/src/set.c
+++ b/src/set.c
@@ -458,7 +458,7 @@ static int nft_set_xml_parse(struct nft_set *s, const char *xml)
s->flags |= (1 << NFT_SET_ATTR_KEY_TYPE);
if (nft_mxml_num_parse(tree, "key_len", MXML_DESCEND_FIRST,
- BASE_DEC, &s->key_type, NFT_TYPE_U32) != 0)
+ BASE_DEC, &s->key_len, NFT_TYPE_U32) != 0)
goto err;
s->flags |= (1 << NFT_SET_ATTR_KEY_LEN);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [libnftables PATCH] set: xml: fix key_type parsing
2013-09-04 16:03 [libnftables PATCH] set: xml: fix key_type parsing Arturo Borrero Gonzalez
@ 2013-09-05 8:53 ` Pablo Neira Ayuso
2013-09-05 8:58 ` Arturo Borrero Gonzalez
0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2013-09-05 8:53 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: netfilter-devel
On Wed, Sep 04, 2013 at 06:03:25PM +0200, Arturo Borrero Gonzalez wrote:
> Bug introduced by myself at 44928cd5 [set: add XML parsing]
Applied.
Please, investigate why the json/xml test infrastructure did not catch
up this. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [libnftables PATCH] set: xml: fix key_type parsing
2013-09-05 8:53 ` Pablo Neira Ayuso
@ 2013-09-05 8:58 ` Arturo Borrero Gonzalez
2013-09-05 9:08 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Arturo Borrero Gonzalez @ 2013-09-05 8:58 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Netfilter Development Mailing list
On 5 September 2013 10:53, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Wed, Sep 04, 2013 at 06:03:25PM +0200, Arturo Borrero Gonzalez wrote:
>> Bug introduced by myself at 44928cd5 [set: add XML parsing]
>
> Applied.
>
> Please, investigate why the json/xml test infrastructure did not catch
> up this. Thanks.
The current testfiles for set uses the same value both in key_type and key_len.
In fact, I discovered this bug using nft-parsing-test, but with
others, additional files.
--
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [libnftables PATCH] set: xml: fix key_type parsing
2013-09-05 8:58 ` Arturo Borrero Gonzalez
@ 2013-09-05 9:08 ` Pablo Neira Ayuso
0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2013-09-05 9:08 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: Netfilter Development Mailing list
On Thu, Sep 05, 2013 at 10:58:02AM +0200, Arturo Borrero Gonzalez wrote:
> On 5 September 2013 10:53, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Wed, Sep 04, 2013 at 06:03:25PM +0200, Arturo Borrero Gonzalez wrote:
> >> Bug introduced by myself at 44928cd5 [set: add XML parsing]
> >
> > Applied.
> >
> > Please, investigate why the json/xml test infrastructure did not catch
> > up this. Thanks.
>
> The current testfiles for set uses the same value both in key_type and key_len.
I expected something like this.
> In fact, I discovered this bug using nft-parsing-test, but with
> others, additional files.
I see, I think that including such a test to master would be good.
Regards.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-05 9:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 16:03 [libnftables PATCH] set: xml: fix key_type parsing Arturo Borrero Gonzalez
2013-09-05 8:53 ` Pablo Neira Ayuso
2013-09-05 8:58 ` Arturo Borrero Gonzalez
2013-09-05 9:08 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).