From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [libnftables PATCH] set: xml: fix key_type parsing
Date: Thu, 5 Sep 2013 11:08:13 +0200 [thread overview]
Message-ID: <20130905090813.GA5396@localhost> (raw)
In-Reply-To: <CAOkSjBhSTxGXbMA3Yy2mt2JDCgc0eRDaRYjygRUNACrB4BKYZg@mail.gmail.com>
On Thu, Sep 05, 2013 at 10:58:02AM +0200, Arturo Borrero Gonzalez wrote:
> On 5 September 2013 10:53, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Wed, Sep 04, 2013 at 06:03:25PM +0200, Arturo Borrero Gonzalez wrote:
> >> Bug introduced by myself at 44928cd5 [set: add XML parsing]
> >
> > Applied.
> >
> > Please, investigate why the json/xml test infrastructure did not catch
> > up this. Thanks.
>
> The current testfiles for set uses the same value both in key_type and key_len.
I expected something like this.
> In fact, I discovered this bug using nft-parsing-test, but with
> others, additional files.
I see, I think that including such a test to master would be good.
Regards.
prev parent reply other threads:[~2013-09-05 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 16:03 [libnftables PATCH] set: xml: fix key_type parsing Arturo Borrero Gonzalez
2013-09-05 8:53 ` Pablo Neira Ayuso
2013-09-05 8:58 ` Arturo Borrero Gonzalez
2013-09-05 9:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905090813.GA5396@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).