* nfnetlink_queue: shouldn't it be entry->skb?
@ 2013-09-17 5:43 Gao feng
2013-09-17 11:09 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Gao feng @ 2013-09-17 5:43 UTC (permalink / raw)
To: netfilter-devel; +Cc: Pablo Neira Ayuso
skb is the netlink type sk_buff, shouldn't we pass entry->skb to nfqnl_ct_seq_adjust?
Since I'm blocked by how to send proper netlink message to make nfqnl_ct_parse find
out ct :( , I haven't confirmed this problem. :(
diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queu
index 95a98c8..ae2e5c1 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -1009,7 +1009,7 @@ nfqnl_recv_verdict(struct sock *ctnl, struct sk_buff *skb,
verdict = NF_DROP;
if (ct)
- nfqnl_ct_seq_adjust(skb, ct, ctinfo, diff);
+ nfqnl_ct_seq_adjust(entry->skb, ct, ctinfo, diff);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: nfnetlink_queue: shouldn't it be entry->skb?
2013-09-17 5:43 nfnetlink_queue: shouldn't it be entry->skb? Gao feng
@ 2013-09-17 11:09 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-09-17 11:09 UTC (permalink / raw)
To: Gao feng; +Cc: netfilter-devel
On Tue, Sep 17, 2013 at 01:43:48PM +0800, Gao feng wrote:
> skb is the netlink type sk_buff, shouldn't we pass entry->skb to nfqnl_ct_seq_adjust?
> Since I'm blocked by how to send proper netlink message to make nfqnl_ct_parse find
> out ct :( , I haven't confirmed this problem. :(
That's right, I have pushed a patch for this, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-17 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-17 5:43 nfnetlink_queue: shouldn't it be entry->skb? Gao feng
2013-09-17 11:09 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).