From: Holger Eitzenberger <holger@eitzenberger.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [FIX 1/1] sip: add missing RCU reader lock
Date: Fri, 20 Sep 2013 22:20:42 +0200 [thread overview]
Message-ID: <20130920202042.GA3659@imap.eitzenberger.org> (raw)
In-Reply-To: <20130920165539.GA27970@macbook.localnet>
> > I chose to not just extend the first RCU protected area but putting
> > the rcu_read_unlock() down, because there is a 'return' in between.
>
> I'd suggest to do that since your patch still doesn't cover the
> direct_rtp nf_nat_sdp_port_hook dereference. Actually with your patch
> we have unbalanced RCU locking since the direct_rtp case contains
> a "goto err1".
Sure, I'll send a 2nd patch in a new thread.
/Holger
prev parent reply other threads:[~2013-09-20 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 15:52 [FIX 0/1] sip: add missing RCU reader lock in set_expected_rtp_rtcp() Holger Eitzenberger
2013-09-20 15:52 ` [FIX 1/1] sip: add missing RCU reader lock Holger Eitzenberger
2013-09-20 16:55 ` Patrick McHardy
2013-09-20 20:20 ` Holger Eitzenberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920202042.GA3659@imap.eitzenberger.org \
--to=holger@eitzenberger.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).