From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftables PATCH 2/2] src: snprintf: fix buffer lengths
Date: Fri, 27 Sep 2013 16:06:29 +0200 [thread overview]
Message-ID: <20130927140629.GB10107@localhost> (raw)
In-Reply-To: <20130925221308.16997.11502.stgit@nfdev.cica.es>
On Thu, Sep 26, 2013 at 12:13:08AM +0200, Arturo Borrero Gonzalez wrote:
> Use 'len' instead of 'size' as length of the buffer to print.
Applied, thanks.
> While at it, fix invalid JSON offset in snprintf for sets and some
> other minor style issues, such as bad indentations.
I prefer separated patches to address each issue. Please, do so next
time.
next prev parent reply other threads:[~2013-09-27 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 22:13 [libnftables PATCH 1/2] set_elem: xml: avoid code duplication Arturo Borrero Gonzalez
2013-09-25 22:13 ` [libnftables PATCH 2/2] src: snprintf: fix buffer lengths Arturo Borrero Gonzalez
2013-09-27 14:06 ` Pablo Neira Ayuso [this message]
2013-09-27 14:05 ` [libnftables PATCH 1/2] set_elem: xml: avoid code duplication Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927140629.GB10107@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).