* [PATCH] iptables: extensions/GNUMakefile.in use CPPFLAGS
@ 2013-08-19 16:02 Laurence J. Lane
2013-08-19 23:50 ` Jan Engelhardt
0 siblings, 1 reply; 4+ messages in thread
From: Laurence J. Lane @ 2013-08-19 16:02 UTC (permalink / raw)
To: netfilter-devel; +Cc: Laurence J. Lane
From: "Laurence J. Lane" <ljlane@debian.org>
"All other Makefiles add CPPFLAGS to ${COMPILE} (automake), but GNUmakefile.in
doesn't set it."
http://bugs.debian.org/665286
Signed-off-by: Laurence J. Lane <ljlane@debian.org>
---
extensions/GNUmakefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/extensions/GNUmakefile.in b/extensions/GNUmakefile.in
index 14e7c57..be89a17 100644
--- a/extensions/GNUmakefile.in
+++ b/extensions/GNUmakefile.in
@@ -21,7 +21,7 @@ regular_CPPFLAGS = @regular_CPPFLAGS@
kinclude_CPPFLAGS = @kinclude_CPPFLAGS@
AM_CFLAGS = ${regular_CFLAGS}
-AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include -I${top_builddir} -I${top_srcdir}/include ${kinclude_CPPFLAGS}
+AM_CPPFLAGS = ${CPPFLAGS} ${regular_CPPFLAGS} -I${top_builddir}/include -I${top_builddir} -I${top_srcdir}/include ${kinclude_CPPFLAGS}
AM_DEPFLAGS = -Wp,-MMD,$(@D)/.$(@F).d,-MT,$@
AM_LDFLAGS = @noundef_LDFLAGS@
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iptables: extensions/GNUMakefile.in use CPPFLAGS
2013-08-19 16:02 [PATCH] iptables: extensions/GNUMakefile.in use CPPFLAGS Laurence J. Lane
@ 2013-08-19 23:50 ` Jan Engelhardt
2013-08-22 16:44 ` [PATCH v2] " Laurence J. Lane
0 siblings, 1 reply; 4+ messages in thread
From: Jan Engelhardt @ 2013-08-19 23:50 UTC (permalink / raw)
To: Laurence J. Lane; +Cc: netfilter-devel
On Monday 2013-08-19 18:02, Laurence J. Lane wrote:
>From: "Laurence J. Lane" <ljlane@debian.org>
>
>"All other Makefiles add CPPFLAGS to ${COMPILE} (automake), but GNUmakefile.in
> doesn't set it."
CPPFLAGS must come last because it's the uservariable that is supposed
to override everything else.
>-AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include -I${top_builddir} -I${top_srcdir}/include ${kinclude_CPPFLAGS}
>+AM_CPPFLAGS = ${CPPFLAGS} ${regular_CPPFLAGS} -I${top_builddir}/include -I${top_builddir} -I${top_srcdir}/include ${kinclude_CPPFLAGS}
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] iptables: extensions/GNUMakefile.in use CPPFLAGS
2013-08-19 23:50 ` Jan Engelhardt
@ 2013-08-22 16:44 ` Laurence J. Lane
2013-09-27 14:44 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Laurence J. Lane @ 2013-08-22 16:44 UTC (permalink / raw)
To: netfilter-devel; +Cc: Laurence J. Lane
"All other Makefiles add CPPFLAGS to ${COMPILE} (automake), but GNUmakefile.in
doesn't set it."
http://bugs.debian.org/665286
Signed-off-by: Laurence J. Lane <ljlane@debian.org>
---
extensions/GNUmakefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/extensions/GNUmakefile.in b/extensions/GNUmakefile.in
index 14e7c57..c5d8844 100644
--- a/extensions/GNUmakefile.in
+++ b/extensions/GNUmakefile.in
@@ -21,7 +21,7 @@ regular_CPPFLAGS = @regular_CPPFLAGS@
kinclude_CPPFLAGS = @kinclude_CPPFLAGS@
AM_CFLAGS = ${regular_CFLAGS}
-AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include -I${top_builddir} -I${top_srcdir}/include ${kinclude_CPPFLAGS}
+AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include -I${top_builddir} -I${top_srcdir}/include ${kinclude_CPPFLAGS} ${CPPFLAGS}
AM_DEPFLAGS = -Wp,-MMD,$(@D)/.$(@F).d,-MT,$@
AM_LDFLAGS = @noundef_LDFLAGS@
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-27 14:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-19 16:02 [PATCH] iptables: extensions/GNUMakefile.in use CPPFLAGS Laurence J. Lane
2013-08-19 23:50 ` Jan Engelhardt
2013-08-22 16:44 ` [PATCH v2] " Laurence J. Lane
2013-09-27 14:44 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).