From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, mph@one.com
Subject: Re: [PATCH] netfilter: synproxy: fix BUG_ON triggered by corrupt TCP packets
Date: Mon, 30 Sep 2013 12:45:54 +0200 [thread overview]
Message-ID: <20130930104554.GA5462@localhost> (raw)
In-Reply-To: <1380527506-27585-1-git-send-email-kaber@trash.net>
On Mon, Sep 30, 2013 at 08:51:46AM +0100, Patrick McHardy wrote:
> TCP packets hitting the SYN proxy through the SYNPROXY target are not
> validated by TCP conntrack. When th->doff is below 5, an underflow happens
> when calculating the options length, causing skb_header_pointer() to
> return NULL and triggering the BUG_ON().
>
> Handle this case gracefully by checking for NULL instead of using BUG_ON().
Applied, thanks Patrick!
prev parent reply other threads:[~2013-09-30 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 7:51 [PATCH] netfilter: synproxy: fix BUG_ON triggered by corrupt TCP packets Patrick McHardy
2013-09-30 10:43 ` Jesper Dangaard Brouer
2013-09-30 10:45 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930104554.GA5462@localhost \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=mph@one.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).