From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>,
Alvaro Neira Ayuso <alvaroneay@gmail.com>
Subject: Re: [libnftables PATCH 2/3] table: json: fix json style
Date: Tue, 1 Oct 2013 11:43:58 +0200 [thread overview]
Message-ID: <20131001094358.GA7573@localhost> (raw)
In-Reply-To: <CAOkSjBgtDpNAJ0zHbpJ417+rdnse0gstAHqgEQqiNo9BSRv+Jw@mail.gmail.com>
On Mon, Sep 30, 2013 at 11:55:25PM +0200, Arturo Borrero Gonzalez wrote:
> On 30 September 2013 20:34, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Mon, Sep 30, 2013 at 11:06:44AM -0700, Stephen Hemminger wrote:
> >> On Mon, 30 Sep 2013 17:05:57 +0200
> >> Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> wrote:
> >>
> >> > Be consistent in JSON style.
> >> >
> >> > Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> >>
> >> All the effort to format and add whitespace in JSON is not that important
> >> since it is intended to be parsed by something, and parsers ignore it.
> >> Many applications just use as little whitespace as possible to reduce size
> >> of output!
> >
> > Thanks Stephen, we'll stick to using as little whitespace as possible.
> >
> > Moreover, there are tools and functions (included in libjansson) to
> > make this human friendly, in case anyone needs it.
>
> I also don't care so much about the format, actually (white spaces or
> not..). I just tried to give some consistency.
>
> { \"rule\":
> { \"chain\":
> { \"set\":
> {\"table\" :
For consistency, please send me a patch to remove the spaces. Thanks!
next prev parent reply other threads:[~2013-10-01 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 15:05 [libnftables PATCH 1/3] tests: fix error reporting Arturo Borrero Gonzalez
2013-09-30 15:05 ` [libnftables PATCH 2/3] table: json: fix json style Arturo Borrero Gonzalez
2013-09-30 17:43 ` Pablo Neira Ayuso
2013-09-30 18:06 ` Stephen Hemminger
2013-09-30 18:34 ` Pablo Neira Ayuso
2013-09-30 21:55 ` Arturo Borrero Gonzalez
2013-10-01 9:43 ` Pablo Neira Ayuso [this message]
2013-09-30 15:06 ` [libnftables PATCH 3/3] src: add low-level ruleset API Arturo Borrero Gonzalez
2013-09-30 17:46 ` Pablo Neira Ayuso
2013-09-30 17:41 ` [libnftables PATCH 1/3] tests: fix error reporting Pablo Neira Ayuso
2013-09-30 22:02 ` Arturo Borrero Gonzalez
2013-10-01 9:45 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001094358.GA7573@localhost \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).