* [iptables-nftables PATCH] xtables: arp: Parse properly target's options
@ 2013-10-03 12:26 Tomasz Bursztyka
2013-10-03 13:00 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Bursztyka @ 2013-10-03 12:26 UTC (permalink / raw)
To: netfilter-devel; +Cc: Tomasz Bursztyka
Without this, target never gets its options parsed, so it's a bug.
Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
---
iptables/xtables-arp.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/iptables/xtables-arp.c b/iptables/xtables-arp.c
index 8072d90..147c371 100644
--- a/iptables/xtables-arp.c
+++ b/iptables/xtables-arp.c
@@ -1317,16 +1317,16 @@ int do_commandarp(struct nft_handle *h, int argc, char *argv[], char **table)
exit_tryhelp(2);
default:
+ if (target) {
+ xtables_option_tfcall(target);
+ xtables_option_tpcall(c, argv,
+ invert, target, &fw);
+ }
break;
}
invert = FALSE;
}
- if (target)
- xtables_option_tfcall(target);
-
- /* Fix me: must put inverse options checking here --MN */
-
if (optind < argc)
xtables_error(PARAMETER_PROBLEM,
"unknown arguments found on commandline");
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [iptables-nftables PATCH] xtables: arp: Parse properly target's options
2013-10-03 12:26 [iptables-nftables PATCH] xtables: arp: Parse properly target's options Tomasz Bursztyka
@ 2013-10-03 13:00 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-10-03 13:00 UTC (permalink / raw)
To: Tomasz Bursztyka; +Cc: netfilter-devel
On Thu, Oct 03, 2013 at 03:26:17PM +0300, Tomasz Bursztyka wrote:
> Without this, target never gets its options parsed, so it's a bug.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-03 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-03 12:26 [iptables-nftables PATCH] xtables: arp: Parse properly target's options Tomasz Bursztyka
2013-10-03 13:00 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).