From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] iptables-nftables nft: Removes if_nametoindex ,NFT_META_OIF for outiface Date: Fri, 11 Oct 2013 11:50:12 +0200 Message-ID: <20131011095012.GA4787@localhost> References: <20131011081525.GA4127@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Anand Raj Manickam Return-path: Received: from mail.us.es ([193.147.175.20]:37929 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757432Ab3JKJuU (ORCPT ); Fri, 11 Oct 2013 05:50:20 -0400 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Fri, Oct 11, 2013 at 03:05:05PM +0530, Anand Raj Manickam wrote: > On Fri, Oct 11, 2013 at 1:45 PM, Pablo Neira Ayuso wrote: > > On Fri, Oct 11, 2013 at 11:34:04AM +0530, Anand Raj Manickam wrote: > >> This patch fixes the issue where , the Rules are added for non > >> existent interface and unable to delete. > >> eg xtables -t nat -I POSTROUTING -o eth10.10 -j MASQUERADE , allows > >> you to add the rule , where eth10.10 interface is not created. > >> But will not allow to delete as the label maps to * by if_nametoindex(). > > > > This patch doesn't apply: > > > > patch -p1 < /tmp/anand.patch > > patching file iptables/nft-shared.c > > patch: **** malformed patch at line 6: *iface, int invflags) > > > > Please, no need to split things in that many chunks per file. One > > single patch file to address one thing is just fine, the repository > > has to remain in consistent state between patches. > > > > Thanks. > > Merged all into a single patch. I still think this still breaks -i eth+ matching, as there was special handling for that case.