From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Simon Horman <horms@verge.net.au>
Cc: Julian Anastasov <ja@ssi.bg>,
lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>
Subject: Re: [PATCH 2/3] ipvs: avoid rcu_barrier during netns cleanup
Date: Thu, 17 Oct 2013 10:11:42 +0200 [thread overview]
Message-ID: <20131017081142.GA5324@localhost> (raw)
In-Reply-To: <20131017004939.GB21728@verge.net.au>
On Thu, Oct 17, 2013 at 09:49:39AM +0900, Simon Horman wrote:
> On Wed, Oct 16, 2013 at 10:52:14PM +0300, Julian Anastasov wrote:
> >
> > Hello,
> >
> > On Wed, 16 Oct 2013, Pablo Neira Ayuso wrote:
> >
> > > I can enqueue this fix to nf if you like. No need to resend, I can
> > > manually apply.
> > >
> > > Let me know.
> >
> > It is not critical. I waited weeks the net tree to be
> > copied into net-next because it collides with the recent
> > "ipvs: make the service replacement more robust" change in
> > net tree :) But if a rcu_barrier in the netns cleanup looks
> > scary enough you can push it to nf. IMHO, it just adds
> > unneeded delay there.
>
> If it is not critical I would prefer for it to travel through
> nf-next. Though I do not feel strongly about this.
Will enqueue for nf-next.
I'd appreciate if you can recover the tradition of attaching a short
evaluation in the cover letter as I do when I send pull requests to
David. Thanks!
next prev parent reply other threads:[~2013-10-17 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 2:01 [GIT PULL] IPVS updates for v3.13 Simon Horman
2013-10-15 2:01 ` [PATCH 1/3] ipvs: fix the IPVS_CMD_ATTR_MAX definition Simon Horman
2013-10-15 2:01 ` [PATCH 2/3] ipvs: avoid rcu_barrier during netns cleanup Simon Horman
2013-10-16 10:43 ` Pablo Neira Ayuso
2013-10-16 19:52 ` Julian Anastasov
2013-10-17 0:49 ` Simon Horman
2013-10-17 8:11 ` Pablo Neira Ayuso [this message]
2013-10-17 8:30 ` Simon Horman
2013-10-15 2:01 ` [PATCH 3/3] ipvs: improved SH fallback strategy Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017081142.GA5324@localhost \
--to=pablo@netfilter.org \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).