From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 2/3] ipvs: avoid rcu_barrier during netns cleanup Date: Thu, 17 Oct 2013 10:11:42 +0200 Message-ID: <20131017081142.GA5324@localhost> References: <1381802507-7934-1-git-send-email-horms@verge.net.au> <1381802507-7934-3-git-send-email-horms@verge.net.au> <20131016104306.GA10288@localhost> <20131017004939.GB21728@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Julian Anastasov , lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Wensong Zhang To: Simon Horman Return-path: Content-Disposition: inline In-Reply-To: <20131017004939.GB21728@verge.net.au> Sender: lvs-devel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Thu, Oct 17, 2013 at 09:49:39AM +0900, Simon Horman wrote: > On Wed, Oct 16, 2013 at 10:52:14PM +0300, Julian Anastasov wrote: > > > > Hello, > > > > On Wed, 16 Oct 2013, Pablo Neira Ayuso wrote: > > > > > I can enqueue this fix to nf if you like. No need to resend, I can > > > manually apply. > > > > > > Let me know. > > > > It is not critical. I waited weeks the net tree to be > > copied into net-next because it collides with the recent > > "ipvs: make the service replacement more robust" change in > > net tree :) But if a rcu_barrier in the netns cleanup looks > > scary enough you can push it to nf. IMHO, it just adds > > unneeded delay there. > > If it is not critical I would prefer for it to travel through > nf-next. Though I do not feel strongly about this. Will enqueue for nf-next. I'd appreciate if you can recover the tradition of attaching a short evaluation in the cover letter as I do when I send pull requests to David. Thanks!