From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Oester <kernel@linuxace.com>, f@localhost
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nftables: operational limit match
Date: Tue, 22 Oct 2013 10:55:40 +0200 [thread overview]
Message-ID: <20131022085540.GA22591@localhost> (raw)
In-Reply-To: <20131005164456.GB16881@home>
On Sat, Oct 05, 2013 at 09:44:56AM -0700, Phil Oester wrote:
> The nft limit match currently does not work at all. Below patches to nftables,
> libnftables, and kernel address the issue. A few notes on the implementation:
>
> - Removed support for nano/micro/milli second limits. These seem pointless,
> given we are using jiffies in the limit match, not a hpet. And who really
> needs to limit items down to sub-second level??
>
> - 'depth' member is removed as unnecessary. All we need in the kernel is the
> rate and the unit.
>
> - 'stamp' member becomes the time we need to next refresh the token bucket,
> instead of being updated on every packet which goes through the match.
>
> This closes netfilter bugzilla #827, reported by Eric Leblond.
Applied the userspace chunks to libnftables and nftables, please split
this in three patches next time. The kernel chunk was merged into the
nftables pull request.
Thanks.
prev parent reply other threads:[~2013-10-22 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 16:44 [PATCH] nftables: operational limit match Phil Oester
2013-10-22 8:55 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022085540.GA22591@localhost \
--to=pablo@netfilter.org \
--cc=f@localhost \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).