From: Florian Westphal <fw@strlen.de>
To: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] statement: avoid huge rodata array
Date: Tue, 22 Oct 2013 15:12:41 +0200 [thread overview]
Message-ID: <20131022131241.GE12157@breakpoint.cc> (raw)
In-Reply-To: <1382445302-8050-1-git-send-email-fw@strlen.de>
Florian Westphal <fw@strlen.de> wrote:
> commit b259d1a ('src: operational limit match') creates huge
> array, increasing nft binary size from ~240k to ~5m on x86_64.
>
> Use switch statement instead.
Applied,
> +static const char *get_unit(uint64_t u)
> +{
> + switch (u) {
> + case 1: return "seconds";
... after changing this to 'second', spotted by Phil Oester.
next prev parent reply other threads:[~2013-10-22 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 12:35 [PATCH nft] statement: avoid huge rodata array Florian Westphal
2013-10-22 13:12 ` Florian Westphal [this message]
2013-10-22 13:18 ` Pablo Neira Ayuso
2013-10-22 13:15 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022131241.GE12157@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).