From: Florian Westphal <fw@strlen.de>
To: "Pekka Pietikäinen" <pp@ee.oulu.fi>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
edumazet@google.com, netfilter-devel@vger.kernel.org
Subject: Re: netfilter: xt_socket: add XT_SOCKET_NOWILDCARD flag causes behavioural change in userspace?
Date: Thu, 24 Oct 2013 14:51:35 +0200 [thread overview]
Message-ID: <20131024125135.GA993@breakpoint.cc> (raw)
In-Reply-To: <5269121A.3040104@ee.oulu.fi>
Pekka Pietikäinen <pp@ee.oulu.fi> wrote:
> On 24/10/13 15:05, Eric Dumazet wrote:
> >sk_state 7 means TCP_CLOSE
> >
> >I do not see how a TCP_CLOSE socket can be matched...
> >
> Yep, TCP_CLOSE can't be right, sk_state isn't correct with early
> demux perhaps?
What is weird is that early_demux should NOT influence xt_socket
because from the rules you posted you are using this in PREROUTING,
which is before tcp early demux magic.
Do you have any other netfilter rules (-j TPROXY perhaps?) that could
explain why the skb has a socket attached in the first place by
the time it ends up in the netfilter socket match?
[ ip_rcv() orphans the skb before netfilter prerouting, so skb->sk
should be NULL ]
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-24 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 13:33 netfilter: xt_socket: add XT_SOCKET_NOWILDCARD flag causes behavioural change in userspace? Pekka Pietikäinen
2013-10-24 8:28 ` Jari Turkia
2013-10-24 9:52 ` Pablo Neira Ayuso
2013-10-24 10:15 ` Eric Dumazet
2013-10-24 11:21 ` Pekka Pietikäinen
2013-10-24 12:05 ` Eric Dumazet
2013-10-24 12:27 ` Pekka Pietikäinen
2013-10-24 12:51 ` Florian Westphal [this message]
[not found] ` <52691D4F.4080903@ee.oulu.fi>
[not found] ` <20131024132936.GC993@breakpoint.cc>
[not found] ` <52695011.2060902@ee.oulu.fi>
2013-10-24 19:14 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024125135.GA993@breakpoint.cc \
--to=fw@strlen.de \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=pp@ee.oulu.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).