From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nft: nft_set_attr_get_u32 null pointer deref
Date: Sun, 27 Oct 2013 21:34:26 +0100 [thread overview]
Message-ID: <20131027203426.GA9466@localhost> (raw)
In-Reply-To: <20131025165531.GA18336@home>
On Fri, Oct 25, 2013 at 09:55:31AM -0700, Phil Oester wrote:
> As reported by John Sager, nft_set_attr_get_u32 can cause a segfault because
> nft_set_attr_get can return NULL. Check for a non-NULL pointer before
> dereferencing.
>
> This closes netfilter bugzilla #868.
I have mangled this patch to include possible null dereferences in get
operations with rule objects (similar case). Let me know if you see
any issue with my change.
Applied, thanks.
next prev parent reply other threads:[~2013-10-27 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 16:55 [PATCH] nft: nft_set_attr_get_u32 null pointer deref Phil Oester
2013-10-27 20:34 ` Pablo Neira Ayuso [this message]
2013-10-27 23:29 ` Phil Oester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027203426.GA9466@localhost \
--to=pablo@netfilter.org \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).