netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [libnftables PATCH] test: xml: fix malformed ruleset testfile
Date: Mon, 28 Oct 2013 09:58:07 +0100	[thread overview]
Message-ID: <20131028085807.GA3763@localhost> (raw)
In-Reply-To: <CAOkSjBiwg6WOSMGBVr6QHoy3prt4UkeURiPmrWPG74Zfv9eoOw@mail.gmail.com>

On Mon, Oct 28, 2013 at 09:28:22AM +0100, Arturo Borrero Gonzalez wrote:
> On 27 October 2013 21:01, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Thu, Oct 24, 2013 at 05:00:58PM +0200, Arturo Borrero Gonzalez wrote:
> >> Give a new XML ruleset testfile. For some reason, the previous was truncated.
> >> This passed silently as nft-parsing-test is not reporting some errors properly.
> >>
> >> This new file provides:
> >>  * 2 tables
> >>  * 3 chains
> >>  * 2 sets, with and without maps
> >>  * 3 rules with mixed exprs
> >
> > Applied, thanks Arturo.
> 
> something went wrong again. The new testfile is also malformed...

Indeed, it's been truncated, I got your patch from patchwork. It seems
it does like too long lines, check:

http://patchwork.ozlabs.org/patch/285934/

Please, send me a new patch, I'll apply directly from your email.

      reply	other threads:[~2013-10-28  8:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 15:00 [libnftables PATCH] test: xml: fix malformed ruleset testfile Arturo Borrero Gonzalez
2013-10-27 20:01 ` Pablo Neira Ayuso
2013-10-28  8:28   ` Arturo Borrero Gonzalez
2013-10-28  8:58     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131028085807.GA3763@localhost \
    --to=pablo@netfilter.org \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).