From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables 2/3] android: Don't include conflicting headers
Date: Tue, 5 Nov 2013 14:02:48 +0100 [thread overview]
Message-ID: <20131105130248.GA29037@localhost> (raw)
In-Reply-To: <1382813433-20890-3-git-send-email-cernekee@gmail.com>
Hi Kevin,
On Sat, Oct 26, 2013 at 11:50:32AM -0700, Kevin Cernekee wrote:
> <netinet/ip.h> and <linux/ip.h> redefine a couple of structs, including
> iphdr. Handle this the same way as on glibc, i.e. don't include
> <linux/ip.h>.
>
> This change comes from AOSP.
No major objections to this 1/3 and 2/3, but I don't see this patch
here:
https://android.googlesource.com/platform/external/iptables/
Please, tell me if it's the right place to look at. Any plan to
include these patches to AOSP repositories?
Thanks.
next prev parent reply other threads:[~2013-11-05 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 18:50 [PATCH iptables 0/3] Fix build errors on Android Kevin Cernekee
2013-10-26 18:50 ` [PATCH iptables 1/3] android: libiptc: Fix socklen_t type mismatch " Kevin Cernekee
2013-10-28 12:31 ` Jan Engelhardt
2013-10-26 18:50 ` [PATCH iptables 2/3] android: Don't include conflicting headers Kevin Cernekee
2013-11-05 13:02 ` Pablo Neira Ayuso [this message]
2014-01-03 1:28 ` Kevin Cernekee
2013-10-26 18:50 ` [PATCH iptables 3/3] android: build: Blacklist TCPOPTSTRIP on systems that lack TCPOPT_* Kevin Cernekee
2013-11-03 21:48 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105130248.GA29037@localhost \
--to=pablo@netfilter.org \
--cc=cernekee@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).