* [PATCH] netfilter: Fix the format of /proc/net/nf_conntrack_expect
@ 2013-11-12 15:08 Changli Gao
2013-11-13 22:50 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Changli Gao @ 2013-11-12 15:08 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Changli Gao, netfilter-devel
There should not be any white space around `='.
---
net/netfilter/nf_conntrack_expect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_conntrack_expect.c b/net/netfilter/nf_conntrack_expect.c
index 4fd1ca9..151af72 100644
--- a/net/netfilter/nf_conntrack_expect.c
+++ b/net/netfilter/nf_conntrack_expect.c
@@ -517,7 +517,7 @@ static int exp_seq_show(struct seq_file *s, void *v)
? (long)(expect->timeout.expires - jiffies)/HZ : 0);
else
seq_printf(s, "- ");
- seq_printf(s, "l3proto = %u proto=%u ",
+ seq_printf(s, "l3proto=%u proto=%u ",
expect->tuple.src.l3num,
expect->tuple.dst.protonum);
print_tuple(s, &expect->tuple,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: Fix the format of /proc/net/nf_conntrack_expect
2013-11-12 15:08 [PATCH] netfilter: Fix the format of /proc/net/nf_conntrack_expect Changli Gao
@ 2013-11-13 22:50 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-11-13 22:50 UTC (permalink / raw)
To: Changli Gao; +Cc: netfilter-devel
On Tue, Nov 12, 2013 at 11:08:06PM +0800, Changli Gao wrote:
> There should not be any white space around `='.
>
> ---
> net/netfilter/nf_conntrack_expect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nf_conntrack_expect.c b/net/netfilter/nf_conntrack_expect.c
> index 4fd1ca9..151af72 100644
> --- a/net/netfilter/nf_conntrack_expect.c
> +++ b/net/netfilter/nf_conntrack_expect.c
> @@ -517,7 +517,7 @@ static int exp_seq_show(struct seq_file *s, void *v)
> ? (long)(expect->timeout.expires - jiffies)/HZ : 0);
> else
> seq_printf(s, "- ");
> - seq_printf(s, "l3proto = %u proto=%u ",
> + seq_printf(s, "l3proto=%u proto=%u ",
Yes, that doesn't look nice, but that output format is there since
2006 (introduced in 77ab9cff).
This is a legacy interface (we have ctnetlink and the conntrack
utility these days) and I don't want to break backward for
applications parsing that output. I'm not taking this.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-13 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-12 15:08 [PATCH] netfilter: Fix the format of /proc/net/nf_conntrack_expect Changli Gao
2013-11-13 22:50 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).